[GitHub] manuzhang commented on a change in pull request #3497: SPARK-4170 [CORE] Closure problems when running Scala app that "extends App"

[GitBox <gi...@apache.org>]

manuzhang commented on a change in pull request #3497: SPARK-4170 [CORE] Closure problems when running Scala app that "extends App"
URL: https://github.com/apache/spark/pull/3497#discussion_r258412735
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -345,6 +345,11 @@ object SparkSubmit {
         System.exit(CLASS_NOT_FOUND_EXIT_STATUS)
     }
 
+    // SPARK-4170
+    if (classOf[scala.App].isAssignableFrom(mainClass)) {
 
 Review comment:
   @srowen This is not working since the passed in mainClass is not that of the Scala `object` that extends `App`. For example, the mainClass is `Test` while the class of object is `Test$` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org