You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 02:14:09 UTC
[GitHub] [spark] beliefer opened a new pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
beliefer opened a new pull request #32244:
URL: https://github.com/apache/spark/pull/32244
### What changes were proposed in this pull request?
This PR group exception messages in `sql/catalyst/src/main/scala/org/apache/spark/sql/types`.
### Why are the changes needed?
It will largely help with standardization of error messages and its maintenance.
### Does this PR introduce _any_ user-facing change?
No. Error messages remain unchanged.
### How was this patch tested?
No new tests - pass all original tests to make sure it doesn't break any existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-825511978
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-825073350
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137807/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824507796
**[Test build #137759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137759/testReport)** for PR 32244 at commit [`9d35442`](https://github.com/apache/spark/commit/9d35442d31a6b9aa285460f2e42e59ef45322d36).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-823053881
ping @allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-827253560
@allisonwang-db Thanks for you review. @cloud-fan Thanks for you work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-822937066
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42188/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824507938
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137759/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-822937076
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42188/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #32244:
URL: https://github.com/apache/spark/pull/32244#discussion_r617900583
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -305,7 +305,7 @@ object QueryExecutionErrors {
new IllegalStateException("table stats must be specified.")
}
- def unaryMinusCauseOverflowError(originValue: Short): ArithmeticException = {
+ def unaryMinusCauseOverflowError(originValue: AnyVal): ArithmeticException = {
Review comment:
how about making the input `originValue` a String type?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -774,4 +774,55 @@ object QueryExecutionErrors {
new IllegalArgumentException(s"Unexpected: $o")
}
+ def unscaledValueTooLargeForPrecisionError(): Throwable = {
+ new ArithmeticException("Unscaled value too large for precision")
+ }
+
+ def decimalPrecisionExceedsMaxPrecisionError(precision: Int, maxPrecision: Int): Throwable = {
+ new ArithmeticException(
+ s"Decimal precision $precision exceeds max precision $maxPrecision")
+ }
+
+ def outRangeOfDecimalTypeError(str: UTF8String): Throwable = {
Review comment:
`outOfDecimalTypeRangeError`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824463661
**[Test build #137759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137759/testReport)** for PR 32244 at commit [`9d35442`](https://github.com/apache/spark/commit/9d35442d31a6b9aa285460f2e42e59ef45322d36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824874928
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42337/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-826988925
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824483917
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42286/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32244:
URL: https://github.com/apache/spark/pull/32244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824874928
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42337/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-825046208
**[Test build #137807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137807/testReport)** for PR 32244 at commit [`0513677`](https://github.com/apache/spark/commit/0513677ad9d7c5732f71263f362a7c39fd751a07).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824507938
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137759/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824828154
**[Test build #137807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137807/testReport)** for PR 32244 at commit [`0513677`](https://github.com/apache/spark/commit/0513677ad9d7c5732f71263f362a7c39fd751a07).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-823027619
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137659/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-823027619
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137659/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824868359
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42337/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824828154
**[Test build #137807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137807/testReport)** for PR 32244 at commit [`0513677`](https://github.com/apache/spark/commit/0513677ad9d7c5732f71263f362a7c39fd751a07).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-823026214
**[Test build #137659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137659/testReport)** for PR 32244 at commit [`ee008f4`](https://github.com/apache/spark/commit/ee008f433c73ec1b4bb67af44c0108bd9feee28d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-822919322
**[Test build #137659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137659/testReport)** for PR 32244 at commit [`ee008f4`](https://github.com/apache/spark/commit/ee008f433c73ec1b4bb67af44c0108bd9feee28d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824476118
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42286/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-822935712
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42188/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-822937076
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42188/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824463661
**[Test build #137759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137759/testReport)** for PR 32244 at commit [`9d35442`](https://github.com/apache/spark/commit/9d35442d31a6b9aa285460f2e42e59ef45322d36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824479277
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42286/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32244:
URL: https://github.com/apache/spark/pull/32244#discussion_r617978277
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -305,7 +305,7 @@ object QueryExecutionErrors {
new IllegalStateException("table stats must be specified.")
}
- def unaryMinusCauseOverflowError(originValue: Short): ArithmeticException = {
+ def unaryMinusCauseOverflowError(originValue: AnyVal): ArithmeticException = {
Review comment:
I tried. But got the failed.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137759/testReport/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-824483917
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42286/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32244:
URL: https://github.com/apache/spark/pull/32244#discussion_r617978277
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -305,7 +305,7 @@ object QueryExecutionErrors {
new IllegalStateException("table stats must be specified.")
}
- def unaryMinusCauseOverflowError(originValue: Short): ArithmeticException = {
+ def unaryMinusCauseOverflowError(originValue: AnyVal): ArithmeticException = {
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-822919322
**[Test build #137659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137659/testReport)** for PR 32244 at commit [`ee008f4`](https://github.com/apache/spark/commit/ee008f433c73ec1b4bb67af44c0108bd9feee28d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32244: [SPARK-35060][SQL] Group exception messages in sql/types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32244:
URL: https://github.com/apache/spark/pull/32244#issuecomment-825073350
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137807/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org