You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/03/16 12:19:34 UTC
[GitHub] [hudi] peng-xin opened a new pull request #2683: add commons-codec to maven-shade-plugin
peng-xin opened a new pull request #2683:
URL: https://github.com/apache/hudi/pull/2683
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
when i use hbase index,is cause some error like below
org.apache.commons.codec has been relocation to org.apache.hudi.org.apache.commons.codec,but org.apache.commons.codec not in include set.
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] peng-xin edited a comment on pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
peng-xin edited a comment on pull request #2683:
URL: https://github.com/apache/hudi/pull/2683#issuecomment-800367586
> do we really need to fix 0.7.0? we don't typically do that. We can just fix master branch and get it into the future 0.8.0?
master branch has been fix by another one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2683:
URL: https://github.com/apache/hudi/pull/2683#issuecomment-800340732
do we really need to fix 0.7.0? we don't typically do that. We can just fix master branch and get it into the future 0.8.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] peng-xin closed pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
peng-xin closed pull request #2683:
URL: https://github.com/apache/hudi/pull/2683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io commented on pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2683:
URL: https://github.com/apache/hudi/pull/2683#issuecomment-800243025
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=h1) Report
> Merging [#2683](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=desc) (f738c7c) into [release-0.7.0](https://codecov.io/gh/apache/hudi/commit/04731916a5dd782c1f1f248f85085245a4c7ee7d?el=desc) (0473191) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-0.7.0 #2683 +/- ##
================================================
Coverage 50.27% 50.27%
Complexity 3051 3051
================================================
Files 419 419
Lines 18897 18897
Branches 1937 1937
================================================
Hits 9501 9501
Misses 8622 8622
Partials 774 774
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `37.21% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `51.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiflink | `0.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.16% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `65.85% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `66.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.48% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2683:
URL: https://github.com/apache/hudi/pull/2683#issuecomment-800243025
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=h1) Report
> Merging [#2683](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=desc) (f738c7c) into [release-0.7.0](https://codecov.io/gh/apache/hudi/commit/04731916a5dd782c1f1f248f85085245a4c7ee7d?el=desc) (0473191) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-0.7.0 #2683 +/- ##
================================================
Coverage 50.27% 50.27%
Complexity 3051 3051
================================================
Files 419 419
Lines 18897 18897
Branches 1937 1937
================================================
Hits 9501 9501
Misses 8622 8622
Partials 774 774
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `37.21% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `51.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiflink | `0.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.16% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `65.85% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `66.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.48% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2683:
URL: https://github.com/apache/hudi/pull/2683#issuecomment-800243025
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=h1) Report
> Merging [#2683](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=desc) (f738c7c) into [release-0.7.0](https://codecov.io/gh/apache/hudi/commit/04731916a5dd782c1f1f248f85085245a4c7ee7d?el=desc) (0473191) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2683?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-0.7.0 #2683 +/- ##
================================================
Coverage 50.27% 50.27%
Complexity 3051 3051
================================================
Files 419 419
Lines 18897 18897
Branches 1937 1937
================================================
Hits 9501 9501
Misses 8622 8622
Partials 774 774
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `37.21% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `51.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiflink | `0.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.16% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `65.85% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `66.49% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.48% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] peng-xin commented on pull request #2683: add commons-codec to maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
peng-xin commented on pull request #2683:
URL: https://github.com/apache/hudi/pull/2683#issuecomment-800367586
> do we really need to fix 0.7.0? we don't typically do that. We can just fix master branch and get it into the future 0.8.0?
yes,you are right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org