You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/24 20:11:51 UTC

[GitHub] [beam] MarcoRob commented on pull request #22028: pulsar connector accepts auth params

MarcoRob commented on PR #22028:
URL: https://github.com/apache/beam/pull/22028#issuecomment-1165901436

   > Do we handle bad auth in pulsar correctly? i.e. if we pass nulls to a pulsar that requires auth, or pass auth to a pulsar that doesn't?
   I don't think it is being handled the bad auth scenario but we could add a pre-validation for the auth like in [SpannerIO](https://github.com/apache/beam/blob/610323d1e6211f528805c3a6f47bcca0968a206d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java#L807) to validate if contains the correct parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org