You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/06/10 16:10:30 UTC
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18610
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
BaseSequenceScanner assumes that overloads of ProcessRange can continue
working after a parse error (some bytes can be skipped in this case
until the next sync marker) but HdfsAvroScanner::ProcessRange() did not
handle this scenario.
Testing:
- ran core tests
- didn't create new tests - the test was caught by a fuzz test,
it would be great to check whether we actually handle this
scenario, but I am not that familiar with Avro
Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
---
M be/src/exec/hdfs-avro-scanner.cc
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/18610/1
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Patch Set 2: Verified+1 Code-Review+2
The build failure is unrelated (IMPALA-11160), merging this manually
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Jul 2022 14:14:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 13:57:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
BaseSequenceScanner assumes that overloads of ProcessRange can continue
working after a parse error (some bytes can be skipped in this case
until the next sync marker) but HdfsAvroScanner::ProcessRange() did not
handle this scenario.
Testing:
- ran core tests
- didn't create new tests - the test was caught by a fuzz test,
it would be great to check whether we actually handle this
scenario, but I am not that familiar with Avro
Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Reviewed-on: http://gerrit.cloudera.org:8080/18610
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/exec/hdfs-avro-scanner.cc
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Csaba Ringhofer: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8310/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 13:57:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10751/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 16:30:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has removed a vote on this change.
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 13:46:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18610 )
Change subject: IMPALA-10267: Properly handle continued scanning after parse error in HdfsAvroScanner
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8310/
--
To view, visit http://gerrit.cloudera.org:8080/18610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c7ea781cd84033b57ea9ca437378636fda91f
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 18:39:40 +0000
Gerrit-HasComments: No