You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by ngara <gi...@git.apache.org> on 2016/10/26 23:37:23 UTC
[GitHub] trafficserver pull request #1152: TS-5009 CID 1022011 Logically dead code re...
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1152
TS-5009 CID 1022011 Logically dead code removal
Please review - I changed this code to ink_release_assert instead of the following code, which seems to either return '\0' or *b->start(); but will ink_assert in debug mode.
ink_assert(!"out of range");
const: At condition !!b, the value of b must be equal to 0.
null: At condition !!b, the value of b must be NULL.
dead_error_condition: The condition !!b cannot be true.
700 if (unlikely(b)) {
CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return b->start();.
701 return *b->start();
702 }
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngara/trafficserver TS-5009
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1152
----
commit 1d169f17565dfe9f2042bd7a73b92420ab602898
Author: Nathan Garabedian <ng...@users.noreply.github.com>
Date: 2016-10-26T23:14:59Z
TS-5009 CID 1022011 Logically dead code removal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1152
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1004/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1152
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1008/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1152
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1111/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1152: TS-5009 CID 1022011 Logically dead code re...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1152
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1114/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1152
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by ngara <gi...@git.apache.org>.
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
OK, figured it out. removing a variable made the equals signs want to line up differently on a line i didnt modify. Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by ngara <gi...@git.apache.org>.
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
I took a close look at this and I didn't make the change that caused clang-format to fail here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1152
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1152
@ngara I think this is failing because of clang-format. I recommend you copy the pre-commit githook into your .git/hooks tree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by ngara <gi...@git.apache.org>.
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
I put the plugin hook in and got it working. Thanks for the suggestion.
Nathan
> On Oct 26, 2016, at 9:01 PM, Leif Hedstrom <no...@github.com> wrote:
>
> @ngara <https://github.com/ngara> I think this is failing because of clang-format. I recommend you copy the pre-commit githook into your .git/hooks tree.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/trafficserver/pull/1152#issuecomment-256541086>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA51eE0tGOe6QyG0UPgODLOK41L_-Xutks5q4CILgaJpZM4KhylU>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Posted by ngara <gi...@git.apache.org>.
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
Maybe this should be an ink_abort instead of ink_release_assert?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---