You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/07/07 20:11:45 UTC
[kudu-CR] [test] extra time for tserver registration
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7378
Change subject: [test] extra time for tserver registration
......................................................................
[test] extra time for tserver registration
Added extra delay prior to starting the client sample application to
allow for the tserver registration with the master. Also, updated
the TS-->master heartbeat parameters to run the test faster.
This is a follow-up commit for 2fc07eb811f351757a0085a7e318affd120fbaf9.
Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
---
M src/kudu/client/client_samples-test.sh
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/7378/1
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [client_samples-test] wait for tserver registration
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [test] extra time for tserver registration
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [test] extra time for tserver registration
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7378/1/src/kudu/client/client_samples-test.sh
File src/kudu/client/client_samples-test.sh:
Line 193: sleep 3
You can use 'bin/kudu tserver list localhost --format=space | wc -l' and a while loop to make this faster and more robust - loop until the number of lines returned is > 0.
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [client_samples-test] wait for tserver registration
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7378/3/src/kudu/client/client_samples-test.sh
File src/kudu/client/client_samples-test.sh:
Line 199: if ! num_tservers=$($OUTPUT_DIR/kudu tserver list localhost --format=space | \
I think you may want to specify $LOCALHOST_IP:$MASTER_RPC_PORT as the master addr here.
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7378
to look at the new patch set (#2).
Change subject: [client_samples-test] wait for tserver registration
......................................................................
[client_samples-test] wait for tserver registration
Wait for the tserver to register with the master for ~10 seconds max
prior to starting the client sample application. Also, updated the
tserver-->master heartbeat parameters to run the test faster.
This is a follow-up for 2fc07eb811f351757a0085a7e318affd120fbaf9.
Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
---
M src/kudu/client/client_samples-test.sh
1 file changed, 37 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/7378/2
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client_samples-test] wait for tserver registration
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7378/1/src/kudu/client/client_samples-test.sh
File src/kudu/client/client_samples-test.sh:
Line 193: sleep 3
> You can use 'bin/kudu tserver list localhost --format=space | wc -l' and a
That's much better. I didn't realize the kudu utility could be used for that. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client_samples-test] wait for tserver registration
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7378/3/src/kudu/client/client_samples-test.sh
File src/kudu/client/client_samples-test.sh:
Line 199: if ! num_tservers=$($OUTPUT_DIR/kudu tserver list localhost --format=space | \
> I think you may want to specify $LOCALHOST_IP:$MASTER_RPC_PORT as the maste
yep, you are absolutely right. The whole premise of there recent changes is to avoid accidentally using the wrong kudu server.
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7378
to look at the new patch set (#4).
Change subject: [client_samples-test] wait for tserver registration
......................................................................
[client_samples-test] wait for tserver registration
Wait for the tserver to register with the master for ~10 seconds max
prior to starting the client sample application. Also, updated the
tserver-->master heartbeat parameters to run the test faster.
This is a follow-up for 2fc07eb811f351757a0085a7e318affd120fbaf9.
Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
---
M src/kudu/client/client_samples-test.sh
1 file changed, 37 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/7378/4
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [client_samples-test] wait for tserver registration
......................................................................
[client_samples-test] wait for tserver registration
Wait for the tserver to register with the master for ~10 seconds max
prior to starting the client sample application. Also, updated the
tserver-->master heartbeat parameters to run the test faster.
This is a follow-up for 2fc07eb811f351757a0085a7e318affd120fbaf9.
Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Reviewed-on: http://gerrit.cloudera.org:8080/7378
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client_samples-test.sh
1 file changed, 37 insertions(+), 10 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [client samples-test] wait for tserver registration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7378
to look at the new patch set (#3).
Change subject: [client_samples-test] wait for tserver registration
......................................................................
[client_samples-test] wait for tserver registration
Wait for the tserver to register with the master for ~10 seconds max
prior to starting the client sample application. Also, updated the
tserver-->master heartbeat parameters to run the test faster.
This is a follow-up for 2fc07eb811f351757a0085a7e318affd120fbaf9.
Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
---
M src/kudu/client/client_samples-test.sh
1 file changed, 37 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/7378/3
--
To view, visit http://gerrit.cloudera.org:8080/7378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01ee263f00097e300d68bfb40fe4409e55d7402c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>