[jira] [Commented] (HADOOP-9626) Add an interface for any exception to serve up an Exit code

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015299#comment-14015299 ] 

Hadoop QA commented on HADOOP-9626:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12602760/HADOOP-9626-001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ipc.TestIPC
                  org.apache.hadoop.ha.TestZKFailoverControllerStress

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3993//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3993//console

This message is automatically generated.

> Add an interface for any exception to serve up an Exit code
> -----------------------------------------------------------
>
>                 Key: HADOOP-9626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9626
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.1.0-beta
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-9626-001.patch
>
>
> Various exception included exit codes, specifically {{Shell.ExitCodeException}}, {{ExitUtils.ExitException()}}.
> If all exceptions that wanted to pass up an exit code to the main method implemented an interface with the method {{int getExitCode()}}, it'd be easier to extract exit codes from these methods in a unified way, so generating the desired exit codes on the application itself



--
This message was sent by Atlassian JIRA
(v6.2#6252)