You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/05/25 23:48:29 UTC
Review Request 67332: ATLAS-2709: added model for RDBMS types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67332/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
Bugs: ATLAS-2709
https://issues.apache.org/jira/browse/ATLAS-2709
Repository: atlas
Description
-------
added model containing RDBMS typedefs - author: Barbara Eckman
Diffs
-----
addons/models/2000-RDBMS/2010-rdbms_model.json PRE-CREATION
Diff: https://reviews.apache.org/r/67332/diff/1/
Testing
-------
- verified that Atlas successfully loads RDBMS model file contents
Thanks,
Madhan Neethiraj
Re: Review Request 67332: ATLAS-2709: added model for RDBMS types
Posted by Barbara Eckman <ba...@cable.comcast.com>.
> On May 26, 2018, 2:27 p.m., David Radley wrote:
> > addons/models/2000-RDBMS/2010-rdbms_model.json
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/67332/diff/1/?file=2030728#file2030728line7>
> >
> > I wonder if you have seen the open metadata types. There is quite a sophisticated representation of schemas and databases and the like. See the wiki for the details of the types; the ones involving schemas are documented here: https://cwiki.apache.org/confluence/display/ATLAS/Area+5+-+Standards
> >
> > The idea is that these types and the others would be the standard representations of RDMS concepts. I am interested to see whether these types are rich enough to meet your requirements.
Pasting this comment into the right place for a reply. :-)
Hi David, I don't believe the relational piece of the open metadata types was available when I originally needed the rdbms types about 5 months ago. I had actually checked to see if something already existed before creating my own. I confess I didn't check again before submitting my version. They look very similar, though I don't see indexes represented. Also, primary and foreign keys are represented in the open metadata types via tags... Can you tell me why that choice was made? Foreign keys in particular with their source and target tables and columns seem a tad complex for tags...
- Barbara
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67332/#review203934
-----------------------------------------------------------
On May 25, 2018, 11:48 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67332/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 11:48 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2709
> https://issues.apache.org/jira/browse/ATLAS-2709
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added model containing RDBMS typedefs - author: Barbara Eckman
>
>
> Diffs
> -----
>
> addons/models/2000-RDBMS/2010-rdbms_model.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67332/diff/1/
>
>
> Testing
> -------
>
> - verified that Atlas successfully loads RDBMS model file contents
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 67332: ATLAS-2709: added model for RDBMS types
Posted by Barbara Eckman <ba...@cable.comcast.com>.
> On May 26, 2018, 2:27 p.m., David Radley wrote:
> >
Hi David, I don't believe the relational piece of the open metadata types was available when I originally needed the rdbms types about 5 months ago. I had actually checked to see if something already existed before creating my own. I confess I didn't check again before submitting my version. They look very similar, though I don't see indexes represented. Also, primary and foreign keys are represented in the open metadata types via tags... Can you tell me why that choice was made? Foreign keys in particular with their source and target tables and columns seem a tad complex for tags...
- Barbara
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67332/#review203934
-----------------------------------------------------------
On May 25, 2018, 11:48 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67332/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 11:48 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2709
> https://issues.apache.org/jira/browse/ATLAS-2709
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added model containing RDBMS typedefs - author: Barbara Eckman
>
>
> Diffs
> -----
>
> addons/models/2000-RDBMS/2010-rdbms_model.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67332/diff/1/
>
>
> Testing
> -------
>
> - verified that Atlas successfully loads RDBMS model file contents
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 67332: ATLAS-2709: added model for RDBMS types
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67332/#review203934
-----------------------------------------------------------
addons/models/2000-RDBMS/2010-rdbms_model.json
Lines 7 (patched)
<https://reviews.apache.org/r/67332/#comment286309>
I wonder if you have seen the open metadata types. There is quite a sophisticated representation of schemas and databases and the like. See the wiki for the details of the types; the ones involving schemas are documented here: https://cwiki.apache.org/confluence/display/ATLAS/Area+5+-+Standards
The idea is that these types and the others would be the standard representations of RDMS concepts. I am interested to see whether these types are rich enough to meet your requirements.
- David Radley
On May 25, 2018, 11:48 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67332/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 11:48 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2709
> https://issues.apache.org/jira/browse/ATLAS-2709
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added model containing RDBMS typedefs - author: Barbara Eckman
>
>
> Diffs
> -----
>
> addons/models/2000-RDBMS/2010-rdbms_model.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67332/diff/1/
>
>
> Testing
> -------
>
> - verified that Atlas successfully loads RDBMS model file contents
>
>
> Thanks,
>
> Madhan Neethiraj
>
>