You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Yann Le Du (JIRA)" <ji...@codehaus.org> on 2006/01/24 15:56:06 UTC

[jira] Created: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Module SCM URL is resolved as [...]/parent/module regardless of relativePath
----------------------------------------------------------------------------

         Key: MNG-2006
         URL: http://jira.codehaus.org/browse/MNG-2006
     Project: Maven 2
        Type: Bug

  Components: Inheritence and Interpolation  
    Versions: 2.0.2    
 Environment: Maven 2.0.2
Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
    Reporter: Yann Le Du


Quoting Emmanuel Venisse from user list :
Ok, it's a bug in
http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
in assembleScmInheritance method.
This method append parent scm connection url and artifactId without look at relativePath. 

For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html

Project structure :
PROJECT
PROJECT/parent
PROJECT/parent/pom.xml
PROJECT/module
PROJECT/module/pom.xml

parent/pom.xml :
<connection>scm:svn:svn://host/PROJECT/parent/</connection>
<module>../module</module>

module/pom.xml :
<relativePath>../parent/pom.xml</relativePath> 

When I add module in Continuum, its url is resolved as :
scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2006?page=all ]
     
Emmanuel Venisse reopened MNG-2006:
-----------------------------------


patch doesn't work

> Module SCM URL is resolved as [...]/parent/module regardless of relativePath
> ----------------------------------------------------------------------------
>
>          Key: MNG-2006
>          URL: http://jira.codehaus.org/browse/MNG-2006
>      Project: Maven 2
>         Type: Bug

>   Components: Inheritence and Interpolation
>     Versions: 2.0.2
>  Environment: Maven 2.0.2
> Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
>     Reporter: Yann Le Du
>     Assignee: John Casey
>     Priority: Blocker
>      Fix For: 2.0.3

>
>
> Quoting Emmanuel Venisse from user list :
> Ok, it's a bug in
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
> in assembleScmInheritance method.
> This method append parent scm connection url and artifactId without look at relativePath. 
> For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html
> Project structure :
> PROJECT
> PROJECT/parent
> PROJECT/parent/pom.xml
> PROJECT/module
> PROJECT/module/pom.xml
> parent/pom.xml :
> <connection>scm:svn:svn://host/PROJECT/parent/</connection>
> <module>../module</module>
> module/pom.xml :
> <relativePath>../parent/pom.xml</relativePath> 
> When I add module in Continuum, its url is resolved as :
> scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2006?page=comments#action_56878 ] 

Emmanuel Venisse commented on MNG-2006:
---------------------------------------

It's required for Continuum

> Module SCM URL is resolved as [...]/parent/module regardless of relativePath
> ----------------------------------------------------------------------------
>
>          Key: MNG-2006
>          URL: http://jira.codehaus.org/browse/MNG-2006
>      Project: Maven 2
>         Type: Bug

>   Components: Inheritence and Interpolation
>     Versions: 2.0.2
>  Environment: Maven 2.0.2
> Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
>     Reporter: Yann Le Du
>      Fix For: 2.0.3

>
>
> Quoting Emmanuel Venisse from user list :
> Ok, it's a bug in
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
> in assembleScmInheritance method.
> This method append parent scm connection url and artifactId without look at relativePath. 
> For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html
> Project structure :
> PROJECT
> PROJECT/parent
> PROJECT/parent/pom.xml
> PROJECT/module
> PROJECT/module/pom.xml
> parent/pom.xml :
> <connection>scm:svn:svn://host/PROJECT/parent/</connection>
> <module>../module</module>
> module/pom.xml :
> <relativePath>../parent/pom.xml</relativePath> 
> When I add module in Continuum, its url is resolved as :
> scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2006?page=all ]
     
John Casey closed MNG-2006:
---------------------------

    Resolution: Fixed

Implemented the following strategy for determining module path adjustments for URLs:

1. look for module-project file, and parent-project file, and compute directory shift from parent-project <modules/> section based on that.

2. look for module-project artifactId, and parent-project <modules/> section, and match where the artifactid is the last path part for a given module in the parent.

Using <relativePath/> is difficult, since the pom files are not always going to be populated for this method, particularly when computing model inheritance.

This should work in most normal cases. Where it doesn't, it's still possible to override the value in the child pom.

> Module SCM URL is resolved as [...]/parent/module regardless of relativePath
> ----------------------------------------------------------------------------
>
>          Key: MNG-2006
>          URL: http://jira.codehaus.org/browse/MNG-2006
>      Project: Maven 2
>         Type: Bug

>   Components: Inheritence and Interpolation
>     Versions: 2.0.2
>  Environment: Maven 2.0.2
> Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
>     Reporter: Yann Le Du
>     Assignee: John Casey
>     Priority: Blocker
>      Fix For: 2.0.3

>
>
> Quoting Emmanuel Venisse from user list :
> Ok, it's a bug in
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
> in assembleScmInheritance method.
> This method append parent scm connection url and artifactId without look at relativePath. 
> For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html
> Project structure :
> PROJECT
> PROJECT/parent
> PROJECT/parent/pom.xml
> PROJECT/module
> PROJECT/module/pom.xml
> parent/pom.xml :
> <connection>scm:svn:svn://host/PROJECT/parent/</connection>
> <module>../module</module>
> module/pom.xml :
> <relativePath>../parent/pom.xml</relativePath> 
> When I add module in Continuum, its url is resolved as :
> scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2006?page=all ]

John Casey updated MNG-2006:
----------------------------

    Priority: Blocker  (was: Major)

> Module SCM URL is resolved as [...]/parent/module regardless of relativePath
> ----------------------------------------------------------------------------
>
>          Key: MNG-2006
>          URL: http://jira.codehaus.org/browse/MNG-2006
>      Project: Maven 2
>         Type: Bug

>   Components: Inheritence and Interpolation
>     Versions: 2.0.2
>  Environment: Maven 2.0.2
> Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
>     Reporter: Yann Le Du
>     Priority: Blocker
>      Fix For: 2.0.3

>
>
> Quoting Emmanuel Venisse from user list :
> Ok, it's a bug in
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
> in assembleScmInheritance method.
> This method append parent scm connection url and artifactId without look at relativePath. 
> For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html
> Project structure :
> PROJECT
> PROJECT/parent
> PROJECT/parent/pom.xml
> PROJECT/module
> PROJECT/module/pom.xml
> parent/pom.xml :
> <connection>scm:svn:svn://host/PROJECT/parent/</connection>
> <module>../module</module>
> module/pom.xml :
> <relativePath>../parent/pom.xml</relativePath> 
> When I add module in Continuum, its url is resolved as :
> scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2006?page=all ]

Emmanuel Venisse updated MNG-2006:
----------------------------------

    Fix Version: 2.0.3

> Module SCM URL is resolved as [...]/parent/module regardless of relativePath
> ----------------------------------------------------------------------------
>
>          Key: MNG-2006
>          URL: http://jira.codehaus.org/browse/MNG-2006
>      Project: Maven 2
>         Type: Bug

>   Components: Inheritence and Interpolation
>     Versions: 2.0.2
>  Environment: Maven 2.0.2
> Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
>     Reporter: Yann Le Du
>      Fix For: 2.0.3

>
>
> Quoting Emmanuel Venisse from user list :
> Ok, it's a bug in
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
> in assembleScmInheritance method.
> This method append parent scm connection url and artifactId without look at relativePath. 
> For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html
> Project structure :
> PROJECT
> PROJECT/parent
> PROJECT/parent/pom.xml
> PROJECT/module
> PROJECT/module/pom.xml
> parent/pom.xml :
> <connection>scm:svn:svn://host/PROJECT/parent/</connection>
> <module>../module</module>
> module/pom.xml :
> <relativePath>../parent/pom.xml</relativePath> 
> When I add module in Continuum, its url is resolved as :
> scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-2006) Module SCM URL is resolved as [...]/parent/module regardless of relativePath

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2006?page=comments#action_57002 ] 

Emmanuel Venisse commented on MNG-2006:
---------------------------------------

The fix must be done for scm connection url, scm developer connection url, scm url and site url in distributionManagement.

For fixing it,  we need to access to the absolute path of parent and child, so we need to access to Project instead of Model in DefaultModelInheritanceAssembler.
New urls must be calculated with child artifactId, relativePath of parent, parent url and module path used for the child


> Module SCM URL is resolved as [...]/parent/module regardless of relativePath
> ----------------------------------------------------------------------------
>
>          Key: MNG-2006
>          URL: http://jira.codehaus.org/browse/MNG-2006
>      Project: Maven 2
>         Type: Bug

>   Components: Inheritence and Interpolation
>     Versions: 2.0.2
>  Environment: Maven 2.0.2
> Continuum 1.0.2 with maven-scm-*-1.0-beta-3-20060115.041342-*.jar
>     Reporter: Yann Le Du
>      Fix For: 2.0.3

>
>
> Quoting Emmanuel Venisse from user list :
> Ok, it's a bug in
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=306518&view=markup
> in assembleScmInheritance method.
> This method append parent scm connection url and artifactId without look at relativePath. 
> For detailed description see http://www.nabble.com/-m2-Multiprojects-and-inherited-SCM-URLs-t951105.html
> Project structure :
> PROJECT
> PROJECT/parent
> PROJECT/parent/pom.xml
> PROJECT/module
> PROJECT/module/pom.xml
> parent/pom.xml :
> <connection>scm:svn:svn://host/PROJECT/parent/</connection>
> <module>../module</module>
> module/pom.xml :
> <relativePath>../parent/pom.xml</relativePath> 
> When I add module in Continuum, its url is resolved as :
> scm:svn:svn://host/PROJECT/parent/module

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org