You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/25 07:57:00 UTC

[GitHub] [iotdb] wangchao316 commented on a change in pull request #2612: [IOTDB-1138]Do not remove the overlap files which is merging when do snapshot

wangchao316 commented on a change in pull request #2612:
URL: https://github.com/apache/iotdb/pull/2612#discussion_r582614664



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -2182,6 +2182,7 @@ private void removeFullyOverlapFiles(TsFileResource newTsFile, Iterator<TsFileRe
       TsFileResource existingTsFile = iterator.next();
       if (newTsFile.isPlanRangeCovers(existingTsFile)
           && !newTsFile.getTsFile().equals(existingTsFile.getTsFile())
+          && !existingTsFile.isMerging()

Review comment:
       hi ,  I have a qeustion.
   if do not delete file which is merging in snapshot.  after merged finished, this tsfile will merge to a new tsfile..
   this new tsfile will be overlap and snapshot tsfile..  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org