You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2013/03/26 23:03:11 UTC
git commit: WICKET-5112 parentheses are valid in url path
Updated Branches:
refs/heads/master 14d018dab -> ed780cc72
WICKET-5112 parentheses are valid in url path
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ed780cc7
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ed780cc7
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ed780cc7
Branch: refs/heads/master
Commit: ed780cc72eb70a71291a724dbced24e1af56653a
Parents: 14d018d
Author: svenmeier <sv...@apache.org>
Authored: Tue Mar 26 23:02:46 2013 +0100
Committer: svenmeier <sv...@apache.org>
Committed: Tue Mar 26 23:02:46 2013 +0100
----------------------------------------------------------------------
.../wicket/validation/validator/UrlValidator.java | 2 +-
.../validation/validator/UrlValidatorTest.java | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/ed780cc7/wicket-core/src/main/java/org/apache/wicket/validation/validator/UrlValidator.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/validation/validator/UrlValidator.java b/wicket-core/src/main/java/org/apache/wicket/validation/validator/UrlValidator.java
index a259c51..b7eee15 100644
--- a/wicket-core/src/main/java/org/apache/wicket/validation/validator/UrlValidator.java
+++ b/wicket-core/src/main/java/org/apache/wicket/validation/validator/UrlValidator.java
@@ -115,7 +115,7 @@ public class UrlValidator implements IValidator<String>
private static final int PARSE_AUTHORITY_PORT = 4;
private static final int PARSE_AUTHORITY_EXTRA = 5; // Should always be empty.
- private static final String PATH_PATTERN = "^(/[-\\w:@&?=+,.!/~*'%$_;]*)?$";
+ private static final String PATH_PATTERN = "^(/[-\\w:@&?=+,.!/~*'%$_;\\(\\)]*)?$";
private static final String QUERY_PATTERN = "^(.*)$";
http://git-wip-us.apache.org/repos/asf/wicket/blob/ed780cc7/wicket-core/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java b/wicket-core/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java
index 712360f..febc2ad 100644
--- a/wicket-core/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java
@@ -53,6 +53,16 @@ public class UrlValidatorTest extends TestCase
}
/**
+ * WICKET-5112
+ */
+ public void testParentheses()
+ {
+ String[] schemes = { "http" };
+ UrlValidator urlValidator = new UrlValidator(schemes);
+ assertTrue(urlValidator.isValid("http://en.wikipedia.org/wiki/Genus_(mathematics)"));
+ }
+
+ /**
* test
*/
public void testIsValid()