You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/03/15 19:21:29 UTC
[PR] Remove SemVer from Pekko Projection [incubator-pekko-projection]
mdedetrich opened a new pull request, #112:
URL: https://github.com/apache/incubator-pekko-projection/pull/112
See discussion at https://github.com/apache/incubator-pekko-projection/issues/110 for why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer from Slick module [incubator-pekko-projection]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #112:
URL: https://github.com/apache/incubator-pekko-projection/pull/112#discussion_r1533141000
##########
build.sbt:
##########
@@ -82,7 +82,9 @@ lazy val slick =
.settings(Defaults.itSettings)
.settings(Dependencies.slick)
.settings(AutomaticModuleName.settings("pekko.projection.slick"))
- .settings(name := "pekko-projection-slick")
+ .settings(
+ name := "pekko-projection-slick",
+ versionScheme := None)
Review Comment:
Good, but better with some common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer from Slick module [pekko-projection]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #112:
URL: https://github.com/apache/pekko-projection/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer from Pekko Projection [incubator-pekko-projection]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #112:
URL: https://github.com/apache/incubator-pekko-projection/pull/112#issuecomment-2000587667
> I'm not sure why #110 means we don't have a stable set of APIs.
Updating slick will break binary compatibility (most likely)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer from Pekko Projection [incubator-pekko-projection]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #112:
URL: https://github.com/apache/incubator-pekko-projection/pull/112#issuecomment-2000590793
Actually I realized that technically speaking we only need to make the jdbc module of this project not semver compatible, let me update PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer from Pekko Projection [incubator-pekko-projection]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #112:
URL: https://github.com/apache/incubator-pekko-projection/pull/112#issuecomment-2000517887
I'm not sure why #110 means we don't have a stable set of APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer from Slick module [incubator-pekko-projection]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #112:
URL: https://github.com/apache/incubator-pekko-projection/pull/112#discussion_r1533322223
##########
build.sbt:
##########
@@ -82,7 +82,9 @@ lazy val slick =
.settings(Defaults.itSettings)
.settings(Dependencies.slick)
.settings(AutomaticModuleName.settings("pekko.projection.slick"))
- .settings(name := "pekko-projection-slick")
+ .settings(
+ name := "pekko-projection-slick",
+ versionScheme := None)
Review Comment:
What do you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org