You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/11/21 20:40:46 UTC

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…

carterkozak commented on a change in pull request #314: LOG4J2-2707: ArrayIndexOutOfBoundsException in UuidUtil, when MAC add…
URL: https://github.com/apache/logging-log4j2/pull/314#discussion_r349307035
 
 

 ##########
 File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/UuidUtil.java
 ##########
 @@ -65,6 +65,20 @@
 
     static {
         byte[] mac = NetUtils.getMacAddress();
+        LEAST = initialize(mac);
+    }
 
 Review comment:
   This looks much better, thanks! Any chance we can replace the static block entirely?
   
   ```java
   private static final long LEAST = initialize(NetUtils.getMacAddress());
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services