You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2021/06/16 09:13:28 UTC
[tomcat] branch 8.5.x updated: Add expanded unit tests for HEAD and
fix bugs identified in buffering
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new e71fc60 Add expanded unit tests for HEAD and fix bugs identified in buffering
e71fc60 is described below
commit e71fc60180857a84af9dc6e5c1ba131ae9f50aa2
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Jun 3 16:44:41 2021 +0100
Add expanded unit tests for HEAD and fix bugs identified in buffering
---
.../apache/catalina/connector/OutputBuffer.java | 10 +-
test/javax/servlet/http/TestHttpServletDoHead.java | 223 +++++++++++++++++++++
webapps/docs/changelog.xml | 8 +
3 files changed, 236 insertions(+), 5 deletions(-)
diff --git a/java/org/apache/catalina/connector/OutputBuffer.java b/java/org/apache/catalina/connector/OutputBuffer.java
index 958a506..2ee976b 100644
--- a/java/org/apache/catalina/connector/OutputBuffer.java
+++ b/java/org/apache/catalina/connector/OutputBuffer.java
@@ -545,7 +545,7 @@ public class OutputBuffer extends Writer {
while (sOff < sEnd) {
int n = transfer(s, sOff, sEnd - sOff, cb);
sOff += n;
- if (isFull(cb)) {
+ if (sOff < sEnd && isFull(cb)) {
flushCharBuffer();
}
}
@@ -746,7 +746,7 @@ public class OutputBuffer extends Writer {
int n = transfer(src, off, len, bb);
len = len - n;
off = off + n;
- if (isFull(bb)) {
+ if (len > 0 && isFull(bb)) {
flushByteBuffer();
appendByteArray(src, off, len);
}
@@ -798,7 +798,7 @@ public class OutputBuffer extends Writer {
appendByteBuffer(from);
} else {
transfer(from, bb);
- if (isFull(bb)) {
+ if (from.hasRemaining() && isFull(bb)) {
flushByteBuffer();
appendByteBuffer(from);
}
@@ -811,7 +811,7 @@ public class OutputBuffer extends Writer {
}
int limit = bb.capacity();
- while (len >= limit) {
+ while (len > limit) {
realWriteBytes(ByteBuffer.wrap(src, off, limit));
len = len - limit;
off = off + limit;
@@ -829,7 +829,7 @@ public class OutputBuffer extends Writer {
int limit = bb.capacity();
int fromLimit = from.limit();
- while (from.remaining() >= limit) {
+ while (from.remaining() > limit) {
from.limit(from.position() + limit);
realWriteBytes(from.slice());
from.position(from.limit());
diff --git a/test/javax/servlet/http/TestHttpServletDoHead.java b/test/javax/servlet/http/TestHttpServletDoHead.java
new file mode 100644
index 0000000..49105a0
--- /dev/null
+++ b/test/javax/servlet/http/TestHttpServletDoHead.java
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javax.servlet.http;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.io.PrintWriter;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import javax.servlet.ServletException;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
+
+import org.apache.catalina.core.StandardContext;
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.util.buf.ByteChunk;
+import org.apache.tomcat.util.collections.CaseInsensitiveKeyMap;
+
+@RunWith(Parameterized.class)
+public class TestHttpServletDoHead extends TomcatBaseTest {
+
+ // Tomcat has a minimum output buffer size of 8 * 1024.
+ // (8 * 1024) /16 = 512
+
+ private static final String VALID = "** valid data **";
+ private static final String INVALID = "* invalid data *";
+
+ private static final Integer BUFFERS[] = new Integer[] { Integer.valueOf (16), Integer.valueOf(8 * 1024), Integer.valueOf(16 * 1024) };
+
+ private static final Integer COUNTS[] = new Integer[] { Integer.valueOf(0), Integer.valueOf(1),
+ Integer.valueOf(511), Integer.valueOf(512), Integer.valueOf(513),
+ Integer.valueOf(1023), Integer.valueOf(1024), Integer.valueOf(1025) };
+
+ @Parameterized.Parameters(name = "{index}: {0} {1} {2} {3} {4} {5}")
+ public static Collection<Object[]> parameters() {
+
+ List<Object[]> parameterSets = new ArrayList<>();
+ for (Integer buf : BUFFERS) {
+ for (Boolean w : booleans) {
+ for (Integer c1 : COUNTS) {
+ for (ResetType rt : ResetType.values()) {
+ for (Integer c2 : COUNTS) {
+ for (Boolean f : booleans) {
+ parameterSets.add(new Object[] { buf, w, c1, rt, c2, f });
+ }
+ }
+ }
+ }
+ }
+ }
+ return parameterSets;
+ }
+
+ @Parameter(0)
+ public int bufferSize;
+ @Parameter(1)
+ public boolean useWriter;
+ @Parameter(2)
+ public int invalidWriteCount;
+ @Parameter(3)
+ public ResetType resetType;
+ @Parameter(4)
+ public int validWriteCount;
+ @Parameter(5)
+ public boolean explicitFlush;
+
+ @Test
+ public void testDoHead() throws Exception {
+ Tomcat tomcat = getTomcatInstance();
+
+ // No file system docBase required
+ StandardContext ctx = (StandardContext) tomcat.addContext("", null);
+
+ HeadTestServlet s = new HeadTestServlet(bufferSize, useWriter, invalidWriteCount, resetType, validWriteCount, explicitFlush);
+ Tomcat.addServlet(ctx, "HeadTestServlet", s);
+ ctx.addServletMappingDecoded("/test", "HeadTestServlet");
+
+ tomcat.start();
+
+ Map<String,List<String>> getHeaders = new CaseInsensitiveKeyMap<>();
+ String path = "http://localhost:" + getPort() + "/test";
+ ByteChunk out = new ByteChunk();
+
+ int rc = getUrl(path, out, getHeaders);
+ Assert.assertEquals(HttpServletResponse.SC_OK, rc);
+ out.recycle();
+
+ Map<String,List<String>> headHeaders = new HashMap<>();
+ rc = headUrl(path, out, headHeaders);
+ Assert.assertEquals(HttpServletResponse.SC_OK, rc);
+
+ // Headers should be the same (apart from Date)
+ Assert.assertEquals(getHeaders.size(), headHeaders.size());
+ for (Map.Entry<String, List<String>> getHeader : getHeaders.entrySet()) {
+ String headerName = getHeader.getKey();
+ if ("date".equalsIgnoreCase(headerName)) {
+ continue;
+ }
+ Assert.assertTrue(headerName, headHeaders.containsKey(headerName));
+ List<String> getValues = getHeader.getValue();
+ List<String> headValues = headHeaders.get(headerName);
+ Assert.assertEquals(getValues.size(), headValues.size());
+ for (String value : getValues) {
+ Assert.assertTrue(headValues.contains(value));
+ }
+ }
+
+ tomcat.stop();
+ }
+
+
+ private static class HeadTestServlet extends HttpServlet {
+
+ private static final long serialVersionUID = 1L;
+
+ private final int bufferSize;
+ private final boolean useWriter;
+ private final int invalidWriteCount;
+ private final ResetType resetType;
+ private final int validWriteCount;
+ private final boolean explicitFlush;
+
+ private PrintWriter pw = null;
+ private OutputStream os = null;
+
+ public HeadTestServlet(int bufferSize, boolean useWriter, int invalidWriteCount, ResetType resetType,
+ int validWriteCount, boolean explicitFlush) {
+ this.bufferSize = bufferSize;
+ this.useWriter = useWriter;
+ this.invalidWriteCount = invalidWriteCount;
+ this.resetType = resetType;
+ this.validWriteCount = validWriteCount;
+ this.explicitFlush = explicitFlush;
+ }
+
+ @Override
+ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
+ resp.setBufferSize(bufferSize);
+
+ resp.setContentType("text/plain");
+ resp.setCharacterEncoding("UTF-8");
+
+ // Do this rather than repeated calls to getWriter() /
+ // getOutputStream() to ensure that HEAD handling doesn't rely on
+ // replacing the OutputStream / PrintWriter (an earlier
+ // implementation did rely on this)
+ if (useWriter) {
+ pw = resp.getWriter();
+ } else {
+ os = resp.getOutputStream();
+ }
+
+ for (int i = 0; i < invalidWriteCount; i++) {
+ write(INVALID);
+ }
+
+ try {
+ switch (resetType) {
+ case NONE: {
+ break;
+ }
+ case BUFFER: {
+ resp.resetBuffer();
+ break;
+ }
+ case FULL: {
+ resp.reset();
+ break;
+ }
+ }
+ } catch (IllegalStateException ise) {
+ write("\nIllegalStateException\n");
+ }
+
+ for (int i = 0; i < validWriteCount; i++) {
+ write(VALID);
+ }
+
+ if (explicitFlush) {
+ resp.flushBuffer();
+ }
+ }
+
+ private void write(String msg) throws IOException {
+ if (useWriter) {
+ pw.print(msg);
+ } else {
+ os.write(msg.getBytes(StandardCharsets.UTF_8));
+ }
+ }
+ }
+
+
+ private static enum ResetType {
+ NONE,
+ BUFFER,
+ FULL
+ }
+}
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 31b4250..238e94ba 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -162,6 +162,14 @@
<code>1#token</code> to ignore empty elements as per RFC 7230 section 7
instead of treating the presence of empty elements as an error. (markt)
</fix>
+ <fix>
+ Expand the unit tests for <code>HttpServlet.doHead()</code> and correct
+ the flushing of the response buffer. The buffer used to behave as if it
+ was one byte smaller than the configured size. The buffer was flushed
+ (and the response committed if required) when the buffer was full. The
+ buffer is now flushed (and the response committed if required) if the
+ buffer is full and there is more data to write. (markt)
+ </fix>
</changelog>
</subsection>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org