[GitHub] amansinha100 commented on a change in pull request #1488: DRILL-786: Allow CROSS JOIN syntax

[GitBox <gi...@apache.org>]

amansinha100 commented on a change in pull request #1488: DRILL-786: Allow CROSS JOIN syntax
URL: https://github.com/apache/drill/pull/1488#discussion_r225000420
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
 ##########
 @@ -65,6 +68,11 @@
   }
   private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(JoinUtils.class);
 
+  public static final String FAILED_TO_PLAN_CARTESIAN_JOIN = String.format(
+      "This query cannot be planned possibly due to either a cartesian join or an inequality join. " +
 
 Review comment:
   The descriptive error message is good.  However, since it is close to 200 chars..can you pls add a newline after the first statement (In the JIRA you do show the message split up on 2 lines) ?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services