You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stephen Friedrich (JIRA)" <de...@myfaces.apache.org> on 2007/09/30 14:41:50 UTC
[jira] Created: (TRINIDAD-745) Support autocomplete attribute for
input fields
Support autocomplete attribute for input fields
-----------------------------------------------
Key: TRINIDAD-745
URL: https://issues.apache.org/jira/browse/TRINIDAD-745
Project: MyFaces Trinidad
Issue Type: New Feature
Affects Versions: 1.0.3-core
Reporter: Stephen Friedrich
My app has some fields where it isn't useful to have the browser remember and try to auto complete values.
In HTML you can switch that off with the non-standard "autocomplete" attribute.
JSF 1.2 also added the same attribute, but Trinidad is still missing it.
Please see the attached patch for a possible implementation. I added the attribute to all subclasses of InputText, with the exception of InputFile, because the browser (well at least firefox) seems to never auto complete those fields, anyway. To keep in line with the rest of Trinidad's attribute names I used "autoComplete" with an upper case "C".
I have not added/modified any tests, because frankly I did not understand what is currently tested and how it is tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-745) Support autocomplete attribute for
input fields
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610253#action_12610253 ]
Matthias Weßendorf commented on TRINIDAD-745:
---------------------------------------------
and even worse, if the users actually select the value, offered from the bowser.
The browsers (FF, IE, no idea on safari) don't trigger the callback to your onchange property...
> Support autocomplete attribute for input fields
> -----------------------------------------------
>
> Key: TRINIDAD-745
> URL: https://issues.apache.org/jira/browse/TRINIDAD-745
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Affects Versions: 1.0.3-core
> Reporter: Stephen Friedrich
> Assignee: Matthias Weßendorf
> Attachments: autoComplete.patch
>
>
> My app has some fields where it isn't useful to have the browser remember and try to auto complete values.
> In HTML you can switch that off with the non-standard "autocomplete" attribute.
> JSF 1.2 also added the same attribute, but Trinidad is still missing it.
> Please see the attached patch for a possible implementation. I added the attribute to all subclasses of InputText, with the exception of InputFile, because the browser (well at least firefox) seems to never auto complete those fields, anyway. To keep in line with the rest of Trinidad's attribute names I used "autoComplete" with an upper case "C".
> I have not added/modified any tests, because frankly I did not understand what is currently tested and how it is tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-745) Support autocomplete attribute for
input fields
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610252#action_12610252 ]
Matthias Weßendorf commented on TRINIDAD-745:
---------------------------------------------
I think it is worth to add this to Trinidad.
> Support autocomplete attribute for input fields
> -----------------------------------------------
>
> Key: TRINIDAD-745
> URL: https://issues.apache.org/jira/browse/TRINIDAD-745
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Affects Versions: 1.0.3-core
> Reporter: Stephen Friedrich
> Assignee: Matthias Weßendorf
> Attachments: autoComplete.patch
>
>
> My app has some fields where it isn't useful to have the browser remember and try to auto complete values.
> In HTML you can switch that off with the non-standard "autocomplete" attribute.
> JSF 1.2 also added the same attribute, but Trinidad is still missing it.
> Please see the attached patch for a possible implementation. I added the attribute to all subclasses of InputText, with the exception of InputFile, because the browser (well at least firefox) seems to never auto complete those fields, anyway. To keep in line with the rest of Trinidad's attribute names I used "autoComplete" with an upper case "C".
> I have not added/modified any tests, because frankly I did not understand what is currently tested and how it is tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-745) Support autocomplete attribute for
input fields
Posted by "Stephen Friedrich (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Friedrich updated TRINIDAD-745:
---------------------------------------
Status: Patch Available (was: Open)
> Support autocomplete attribute for input fields
> -----------------------------------------------
>
> Key: TRINIDAD-745
> URL: https://issues.apache.org/jira/browse/TRINIDAD-745
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Affects Versions: 1.0.3-core
> Reporter: Stephen Friedrich
>
> My app has some fields where it isn't useful to have the browser remember and try to auto complete values.
> In HTML you can switch that off with the non-standard "autocomplete" attribute.
> JSF 1.2 also added the same attribute, but Trinidad is still missing it.
> Please see the attached patch for a possible implementation. I added the attribute to all subclasses of InputText, with the exception of InputFile, because the browser (well at least firefox) seems to never auto complete those fields, anyway. To keep in line with the rest of Trinidad's attribute names I used "autoComplete" with an upper case "C".
> I have not added/modified any tests, because frankly I did not understand what is currently tested and how it is tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-745) Support autocomplete attribute for
input fields
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated TRINIDAD-745:
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.9-core
1.0.9-core
Status: Resolved (was: Patch Available)
Thanks for the patch.
Committed this feature after some modifications.
> Support autocomplete attribute for input fields
> -----------------------------------------------
>
> Key: TRINIDAD-745
> URL: https://issues.apache.org/jira/browse/TRINIDAD-745
> Project: MyFaces Trinidad
> Issue Type: New Feature
> Affects Versions: 1.0.3-core
> Reporter: Stephen Friedrich
> Assignee: Matthias Weßendorf
> Fix For: 1.0.9-core, 1.2.9-core
>
> Attachments: autoComplete.patch
>
>
> My app has some fields where it isn't useful to have the browser remember and try to auto complete values.
> In HTML you can switch that off with the non-standard "autocomplete" attribute.
> JSF 1.2 also added the same attribute, but Trinidad is still missing it.
> Please see the attached patch for a possible implementation. I added the attribute to all subclasses of InputText, with the exception of InputFile, because the browser (well at least firefox) seems to never auto complete those fields, anyway. To keep in line with the rest of Trinidad's attribute names I used "autoComplete" with an upper case "C".
> I have not added/modified any tests, because frankly I did not understand what is currently tested and how it is tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.