You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/04/27 02:53:48 UTC
Review Request: Added linux /proc utilities in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu.
Description
-------
Part 1 of moving src/linux.{cpp,hpp} into stout.
This was a copy from src/linux/proc.{cpp,hpp}.
Diffs
-----
third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
third_party/libprocess/third_party/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173
third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/10809/diff/
Testing
-------
OSX and Linux: make check
Thanks,
Ben Mahler
Re: Review Request: Added linux /proc utilities in stout.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/#review19849
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On April 27, 2013, 12:54 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10809/
> -----------------------------------------------------------
>
> (Updated April 27, 2013, 12:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu.
>
>
> Description
> -------
>
> Part 1 of moving src/linux/proc.{cpp,hpp} into stout.
>
> This was a copy from src/linux/proc.{cpp,hpp}.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
> third_party/libprocess/third_party/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173
> third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
> third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
> third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10809/diff/
>
>
> Testing
> -------
>
> OSX and Linux: make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added linux /proc utilities in stout.
Posted by Ben Mahler <be...@gmail.com>.
> On April 29, 2013, 5:45 p.m., Benjamin Hindman wrote:
> > third_party/libprocess/third_party/stout/configure.ac, line 15
> > <https://reviews.apache.org/r/10809/diff/1/?file=285204#file285204line15>
> >
> > Don't want to derail this review, but is there a clean way to just use target_os in Makefile.am?
After reading one of your TODOs, I had searched but to no avail. It seems most people use ${target_os} in configure.ac + AM_CONDITIONAL to pump it into the makefile.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/#review19869
-----------------------------------------------------------
On April 27, 2013, 12:54 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10809/
> -----------------------------------------------------------
>
> (Updated April 27, 2013, 12:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu.
>
>
> Description
> -------
>
> Part 1 of moving src/linux/proc.{cpp,hpp} into stout.
>
> This was a copy from src/linux/proc.{cpp,hpp}.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
> third_party/libprocess/third_party/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173
> third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
> third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
> third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10809/diff/
>
>
> Testing
> -------
>
> OSX and Linux: make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added linux /proc utilities in stout.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/#review19869
-----------------------------------------------------------
third_party/libprocess/third_party/stout/Makefile.am
<https://reviews.apache.org/r/10809/#comment40968>
Hmm, I'm not sure this is what you want. We ALWAYS want to include these files in the distribution, we just don't want to build them if we're not on Linux ...
third_party/libprocess/third_party/stout/configure.ac
<https://reviews.apache.org/r/10809/#comment40985>
Don't want to derail this review, but is there a clean way to just use target_os in Makefile.am?
third_party/libprocess/third_party/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/10809/#comment40988>
s|proc|stout/proc|
s/linux systems/Linux/
- Benjamin Hindman
On April 27, 2013, 12:54 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10809/
> -----------------------------------------------------------
>
> (Updated April 27, 2013, 12:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu.
>
>
> Description
> -------
>
> Part 1 of moving src/linux/proc.{cpp,hpp} into stout.
>
> This was a copy from src/linux/proc.{cpp,hpp}.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
> third_party/libprocess/third_party/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173
> third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
> third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
> third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10809/diff/
>
>
> Testing
> -------
>
> OSX and Linux: make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added linux /proc utilities in stout.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/#review19900
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On April 29, 2013, 9:50 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10809/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 9:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Part 1 of moving src/linux/proc.{cpp,hpp} into stout.
>
> This was a copy from src/linux/proc.{cpp,hpp}.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
> third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
> third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
> third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10809/diff/
>
>
> Testing
> -------
>
> OSX and Linux: make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added linux /proc utilities in stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/
-----------------------------------------------------------
(Updated April 29, 2013, 9:50 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Benh review: no longer conditionally including proc.hpp / proc_tests.cpp in the distribution.
Description
-------
Part 1 of moving src/linux/proc.{cpp,hpp} into stout.
This was a copy from src/linux/proc.{cpp,hpp}.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/10809/diff/
Testing
-------
OSX and Linux: make check
Thanks,
Ben Mahler
Re: Review Request: Added linux /proc utilities in stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10809/
-----------------------------------------------------------
(Updated April 27, 2013, 12:54 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu.
Description (updated)
-------
Part 1 of moving src/linux/proc.{cpp,hpp} into stout.
This was a copy from src/linux/proc.{cpp,hpp}.
Diffs
-----
third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a324fbb3403b5b7514b1a1a
third_party/libprocess/third_party/stout/configure.ac 86e1ff369bdcf1056bf2ce7606aa3c910e699173
third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819
third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46
third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/10809/diff/
Testing
-------
OSX and Linux: make check
Thanks,
Ben Mahler