You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/05/01 20:56:05 UTC

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
-----------------------------------------------------------

(Updated May 1, 2015, 8:56 p.m.)


Review request for mesos, Ben Mahler, Marco Massenzio, Niklas Nielsen, and Till Toenshoff.


Changes
-------

Rebased to current master.


Bugs: MESOS-2157
    https://issues.apache.org/jira/browse/MESOS-2157


Repository: mesos


Description
-------

Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.

Adds tests for the endpoints.

Works with [29883](https://reviews.apache.org/r/29883).

Builds on the abandoned patch 14286.


Diffs (updated)
-----

  src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 
  src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd 
  src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e 
  src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501 

Diff: https://reviews.apache.org/r/30612/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review82279
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32198, 32163, 30612]

All tests passed.

- Mesos ReviewBot


On May 1, 2015, 6:56 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 6:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Marco Massenzio, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2157
>     https://issues.apache.org/jira/browse/MESOS-2157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
> 
> Adds tests for the endpoints.
> 
> Works with [29883](https://reviews.apache.org/r/29883).
> 
> Builds on the abandoned patch 14286.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 
>   src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd 
>   src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e 
>   src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501 
> 
> Diff: https://reviews.apache.org/r/30612/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>