You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 15:40:27 UTC
[GitHub] [airflow] swalkowski opened a new issue #12202: Inconsistent styles of different validation errors in Airflow UI
swalkowski opened a new issue #12202:
URL: https://github.com/apache/airflow/issues/12202
**Apache Airflow version**: 1.10.12
**Environment**:
- **Cloud provider or hardware configuration**: Google Cloud Composer (one tweaked environment running RBAC UI, one regular environment running non-RBAC UI)
**What happened**:
Inconsistent styles of different validation errors in Airflow UI. In particular, a validation error for missing field value is a white box with exclamation mark in a yellow square and text in black, while a validation error for incorrect value is in red text (and red box in RBAC UI), styled differently. Examples from the Add Connection form:
- Inconsistency in RBAC UI:
- Inconsistency in non-RBAC UI:
It's just a minor UX problem.
Looking at the page behavior, I guess the difference comes from client-side vs. server-side validation.
**What you expected to happen**:
Consistent style for all validation errors, in a single form but also across pages.
**How to reproduce it**:
For example: in Airflow UI go to Connections, click Add a new record, select Redis as connection type, write some characters in Conn Id field, put `{{{` in the Port field, click Save, clear the Conn Id field, click Save - you will now see both error styles in a single form.
+cc @ryanahamilton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton edited a comment on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
ryanahamilton edited a comment on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724103395
For some additional context, the "please fill out this field" messages are native browser rendered input validation based on the input having a `required` attribute, and the others are custom validation within the application. This is unchanged in 2.0. This form is rendered by [FAB](https://github.com/dpgaspar/Flask-AppBuilder), so if we wanted to change it, it would have to be PR'ed to FAB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724105899
So i'd say it's something we might not even want to deal with, I am afraid. Looks like the effort is not worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724107611
@potiuk yeah, I think I'd agree with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724092297
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724103395
For some additional context, the "please fill out this field" messages are native browser rendered input validation based on the input having a `required` attribute, and the others are custom validation within the application. This is unchanged in 2.0. This form is rendered by FAB, so if we wanted to change it, it would have to be PR'ed to FAB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724291083
@swalkowski - I think we should close it then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12202:
URL: https://github.com/apache/airflow/issues/12202#issuecomment-724099681
I guess @ryanahamilton that this is similar for 2.0? Or have we already unified it? I am happy to cherry-pick some changes to 1.10.13 if they might be simple and you can guide me - to make life of the 1.10.* folks a bit better on that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #12202: Inconsistent styles of different validation errors in Airflow UI
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #12202:
URL: https://github.com/apache/airflow/issues/12202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org