You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by rj...@apache.org on 2013/02/11 17:56:53 UTC
svn commit: r1444861 -
/incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Author: rjollos
Date: Mon Feb 11 16:56:53 2013
New Revision: 1444861
URL: http://svn.apache.org/r1444861
Log:
Refs #270: Redirect to Guide/RepositoryAdmin when repository browsing hasn't been configured.
Modified:
incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Modified: incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
URL: http://svn.apache.org/viewvc/incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py?rev=1444861&r1=1444860&r2=1444861&view=diff
==============================================================================
--- incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py (original)
+++ incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py Mon Feb 11 16:56:53 2013
@@ -339,7 +339,7 @@ class BloodhoundTheme(ThemeBase):
if bm and not list(bm.get_navigation_items(req)):
yield ('mainnav', 'browser',
tag.a(_('Browse Source'),
- href=req.href.wiki('TracRepositoryAdmin')))
+ href=req.href.wiki('Guide/RepositoryAdmin')))
class QuickCreateTicketDialog(Component):
implements(IRequestFilter, IRequestHandler)
Re: svn commit: r1444861 - /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Posted by Ryan Ollos <ry...@wandisco.com>.
On Tue, Feb 12, 2013 at 3:25 AM, Peter Koželj <pe...@digiverse.si> wrote:
> This change should not be necessary. If wiki pages were renamed, theme
> postprocessing /should/ take care of the wiki links.
> The problem I have with this commit is that this link will not work if used
> with environment where wiki pages have not been renamed yet.
I will revert the change and try to hunt down the real issue. Thank you for
reviewing.
Re: svn commit: r1444861 - /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Posted by Ryan Ollos <ry...@wandisco.com>.
On Tue, Feb 12, 2013 at 3:36 AM, Gary Martin <ga...@wandisco.com>wrote:
> I have not found this to be a problem before. Do we know the circumstances
> that it doesn't work?
>
I have no clues yet, but I will spend some time investigating today or
tomorrow.
Re: svn commit: r1444861 - /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Posted by Olemis Lang <ol...@gmail.com>.
On 2/12/13, Gary Martin <ga...@wandisco.com> wrote:
> On 12/02/13 11:25, Peter Koželj wrote:
>> This change should not be necessary. If wiki pages were renamed, theme
>> postprocessing /should/ take care of the wiki links.
>> The problem I have with this commit is that this link will not work if
>> used
>> with environment where wiki pages have not been renamed yet.
>>
>
> I have not found this to be a problem before. Do we know the
> circumstances that it doesn't work?
Suggestion : Why not to write a test case for this ? Everything will
be more clear and there will be a systematic way to track regressions
. In general , afaics , there are few or no test cases for some
important features (e.g. whitelabeling , widgets , ... ) and , over
time , we should work towards achieving more coverage ... but maybe
this is the right time to tackle this particular case .
--
Regards,
Olemis.
Re: svn commit: r1444861 - /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Posted by Gary Martin <ga...@wandisco.com>.
I have not found this to be a problem before. Do we know the
circumstances that it doesn't work?
Cheers,
Gary
On 12/02/13 11:25, Peter Koželj wrote:
> This change should not be necessary. If wiki pages were renamed, theme
> postprocessing /should/ take care of the wiki links.
> The problem I have with this commit is that this link will not work if used
> with environment where wiki pages have not been renamed yet.
>
> Peter
>
> On 11 February 2013 17:56, <rj...@apache.org> wrote:
>
>> Author: rjollos
>> Date: Mon Feb 11 16:56:53 2013
>> New Revision: 1444861
>>
>> URL: http://svn.apache.org/r1444861
>> Log:
>> Refs #270: Redirect to Guide/RepositoryAdmin when repository browsing
>> hasn't been configured.
>>
>> Modified:
>> incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
>>
>> Modified: incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
>> URL:
>> http://svn.apache.org/viewvc/incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py?rev=1444861&r1=1444860&r2=1444861&view=diff
>>
>> ==============================================================================
>> --- incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py (original)
>> +++ incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py Mon Feb
>> 11 16:56:53 2013
>> @@ -339,7 +339,7 @@ class BloodhoundTheme(ThemeBase):
>> if bm and not list(bm.get_navigation_items(req)):
>> yield ('mainnav', 'browser',
>> tag.a(_('Browse Source'),
>> - href=req.href.wiki('TracRepositoryAdmin')))
>> + href=req.href.wiki('Guide/RepositoryAdmin')))
>>
>> class QuickCreateTicketDialog(Component):
>> implements(IRequestFilter, IRequestHandler)
>>
>>
>>
Re: svn commit: r1444861 - /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Posted by Ryan Ollos <ry...@wandisco.com>.
On Tue, Feb 12, 2013 at 3:25 AM, Peter Koželj <pe...@digiverse.si> wrote:
> This change should not be necessary. If wiki pages were renamed, theme
> postprocessing /should/ take care of the wiki links.
> The problem I have with this commit is that this link will not work if used
> with environment where wiki pages have not been renamed yet.
It should be backed out now.
It's time to clear my head when I have to reverse merge changes committed
in my attempted reverse merge ;)
Re: svn commit: r1444861 - /incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Posted by Peter Koželj <pe...@digiverse.si>.
This change should not be necessary. If wiki pages were renamed, theme
postprocessing /should/ take care of the wiki links.
The problem I have with this commit is that this link will not work if used
with environment where wiki pages have not been renamed yet.
Peter
On 11 February 2013 17:56, <rj...@apache.org> wrote:
> Author: rjollos
> Date: Mon Feb 11 16:56:53 2013
> New Revision: 1444861
>
> URL: http://svn.apache.org/r1444861
> Log:
> Refs #270: Redirect to Guide/RepositoryAdmin when repository browsing
> hasn't been configured.
>
> Modified:
> incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
>
> Modified: incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
> URL:
> http://svn.apache.org/viewvc/incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py?rev=1444861&r1=1444860&r2=1444861&view=diff
>
> ==============================================================================
> --- incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py (original)
> +++ incubator/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py Mon Feb
> 11 16:56:53 2013
> @@ -339,7 +339,7 @@ class BloodhoundTheme(ThemeBase):
> if bm and not list(bm.get_navigation_items(req)):
> yield ('mainnav', 'browser',
> tag.a(_('Browse Source'),
> - href=req.href.wiki('TracRepositoryAdmin')))
> + href=req.href.wiki('Guide/RepositoryAdmin')))
>
> class QuickCreateTicketDialog(Component):
> implements(IRequestFilter, IRequestHandler)
>
>
>