maybe bug

[Djokic Vladimir <dj...@sezampro.yu>]

In class LifecycleImpl,

method ,

1: private boolean executePhase(FacesContext facesContext, PhaseExecutor
executor,
2:    		PhaseListenerManager phaseListenerMgr) throws FacesException {
3:		boolean skipFurtherProcessing = false;
4:        if (log.isTraceEnabled()) {
5:        	log.trace("entering " + executor.getPhase() + " in " +
LifecycleImpl.class.getName());
6:        }
7:
8:        try {
9:           
phaseListenerMgr.informPhaseListenersBefore(executor.getPhase());
10:
11:            if(isResponseComplete(facesContext, executor.getPhase(),
true)) {
12:               // have to return right away
13:            	return true;
14:            }
15:           if(shouldRenderResponse(facesContext, executor.getPhase(),
true)) {
16:            	skipFurtherProcessing = true;
17:            }
18:
19:           if(executor.execute(facesContext)) {
20:            	return true;
21:            }
22:        } finally {
23:          
phaseListenerMgr.informPhaseListenersAfter(executor.getPhase());
24:        }
25:
26:        if (isResponseComplete(facesContext, executor.getPhase(), false)
27:        		|| shouldRenderResponse(facesContext, executor.getPhase(),
false)) {
28:        	// since this phase is completed we don't need to return right
away even if the response is 
29:        	skipFurtherProcessing = true;
30:        }
31:
32:        if (!skipFurtherProcessing && log.isTraceEnabled()) {
33:			log.trace("exiting " + executor.getPhase() + " in " +
LifecycleImpl.class.getName());
34:       }
35:
36:        return skipFurtherProcessing;
37:   }

In line 16 we have "skipFurtherProcessing = true;"

Should be "return true;"???

Sorry for bed english!!!















-- 
View this message in context: http://www.nabble.com/maybe-bug-tf4024012.html#a11429586
Sent from the My Faces - Dev mailing list archive at Nabble.com.