You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "shoemoney (via GitHub)" <gi...@apache.org> on 2026/08/25 20:35:22 UTC

[PR] fix(planner): add missing flink-table-code-splitter test dependency [flink]

shoemoney opened a new pull request, #29019:
URL: https://github.com/apache/flink/pull/29019

   Fixes planner test compilation failure.
   
   **Bug:** `flink-table/flink-table-planner/pom.xml` at line 176 has no dependency on `flink-table-code-splitter`, but `JsonParseReuseTest.java:32` imports `org.apache.flink.table.codesplit.JavaCodeSplitter`. Any `mvn -Dtest=CreateConnectionITCase` invocation fails to compile the test sources.
   
   **Fix:** Add test-scoped dependency on `flink-table-code-splitter` in `flink-table/flink-table-planner/pom.xml`.
   
   **Evidence:** RED verified by stashing the fix and confirming `grep -c flink-table-code-splitter` is 0 while the import remains. GREEN verified after restoring the fix count is 1. Diff is 7 insertions in one file.
   
   Written in conjunction with my pair programmer Claude.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40450][table-planner] Add missing flink-table-code-splitter test dependency [flink]

Posted by "shoemoney (via GitHub)" <gi...@apache.org>.
shoemoney commented on PR #29019:
URL: https://github.com/apache/flink/pull/29019#issuecomment-5731024251

   Thanks for the review, @uros-b. The matching ticket is FLINK-40450, opened 2026-08-20 and still unassigned: https://issues.apache.org/jira/browse/FLINK-40450
   
   I retitled the PR and reworded the commit to `[FLINK-40450][table-planner]` per AGENTS.md. The force-push was message only. The tree is identical to 34067ce (tree 4796875), the revision that passed Azure build 78357, so the diff has not changed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(planner): add missing flink-table-code-splitter test dependency [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29019:
URL: https://github.com/apache/flink/pull/29019#issuecomment-5416509808

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "34067ce508535c3955ada155440738d3a327da20",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "34067ce508535c3955ada155440738d3a327da20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34067ce508535c3955ada155440738d3a327da20 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(planner): add missing flink-table-code-splitter test dependency [flink]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #29019:
URL: https://github.com/apache/flink/pull/29019#issuecomment-5464963770

   Good fix, thank you @shoemoney!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org