You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/23 03:17:27 UTC
[GitHub] [arrow-rs] HaoYang670 opened a new pull request, #1924: MINOR: Replace `checked_add(sub).unwrap()` with `+(-)`
HaoYang670 opened a new pull request, #1924:
URL: https://github.com/apache/arrow-rs/pull/1924
Signed-off-by: remzi <13...@gmail.com>
# Which issue does this PR close?
None.
Related to #1918.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1924: MINOR: Replace `checked_add/sub().unwrap()` with `+/-`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1924:
URL: https://github.com/apache/arrow-rs/pull/1924#issuecomment-1163886204
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1924](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da82e0c) into [master](https://codecov.io/gh/apache/arrow-rs/commit/fc4044f35d4aa67e706c6d3f61a9f24bab5346be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc4044f) will **decrease** coverage by `0.01%`.
> The diff coverage is `87.45%`.
> :exclamation: Current head da82e0c differs from pull request most recent head 4c118b3. Consider uploading reports for the commit 4c118b3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
- Coverage 83.43% 83.41% -0.02%
==========================================
Files 203 214 +11
Lines 56969 57004 +35
==========================================
+ Hits 47531 47550 +19
- Misses 9438 9454 +16
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L21vZC5ycw==) | `100.00% <ø> (ø)` | |
| [arrow/src/compute/kernels/temporal.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy90ZW1wb3JhbC5ycw==) | `94.64% <ø> (ø)` | |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.42% <ø> (-0.38%)` | :arrow_down: |
| [parquet/src/column/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3JlYWRlci5ycw==) | `68.61% <0.00%> (ø)` | |
| [arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2JpbmFyeS5ycw==) | `94.18% <66.66%> (ø)` | |
| [arrow/src/array/builder/decimal\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvZGVjaW1hbF9idWlsZGVyLnJz) | `69.18% <69.18%> (ø)` | |
| [arrow/src/array/builder/boolean\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvYm9vbGVhbl9idWlsZGVyLnJz) | `75.75% <75.75%> (ø)` | |
| [arrow/src/array/builder/union\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvdW5pb25fYnVpbGRlci5ycw==) | `76.99% <76.99%> (ø)` | |
| [arrow/src/array/builder/struct\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvc3RydWN0X2J1aWxkZXIucnM=) | `77.47% <77.47%> (ø)` | |
| [.../src/array/builder/primitive\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvcHJpbWl0aXZlX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `78.18% <78.18%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/arrow-rs/pull/1924/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fc4044f...4c118b3](https://codecov.io/gh/apache/arrow-rs/pull/1924?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1924: MINOR: Replace `checked_add/sub().unwrap()` with `+/-`
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1924:
URL: https://github.com/apache/arrow-rs/pull/1924#issuecomment-1164104472
This pr appears to have what appears to be a broken rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1924: MINOR: Replace `checked_add/sub().unwrap()` with `+/-`
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1924:
URL: https://github.com/apache/arrow-rs/pull/1924#issuecomment-1164357400
It appears to have sorted itself out, it was showing a massive diff of unrelated changes. I think GitHub got confused :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1924: MINOR: Replace `checked_add/sub().unwrap()` with `+/-`
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1924:
URL: https://github.com/apache/arrow-rs/pull/1924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1924: MINOR: Replace `checked_add/sub().unwrap()` with `+/-`
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #1924:
URL: https://github.com/apache/arrow-rs/pull/1924#issuecomment-1164340655
Sorry, I am a little confused about what the `broken rebase` means?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org