You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/12/14 14:36:19 UTC

[GitHub] [avro] zcsizmadia commented on pull request #2009: Avro 3603 dotnet reflect make properties and method virtual in ClassCache, DotnetClass, DotnetProperty

zcsizmadia commented on PR #2009:
URL: https://github.com/apache/avro/pull/2009#issuecomment-1351525170

   My biggest concern is calling the virtual functions from the constructors (see CodeQL complains). I must be addressed before  merging.
   
   Personally , I feel interfaces are a better solution here, but I understand the concerns about them either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org