[GitHub] [kafka] lakamsani commented on pull request #11616: MINOR: update the description in Kraft example properties file

[GitBox <gi...@apache.org>]

lakamsani commented on pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#issuecomment-997454815


   @showuon  thanks for these updates. Very helpful. May I suggest a couple of more doc updates/clarifications in this area? 
   
   1. Wondering if it might be useful to add links to the example [broker only config file](https://github.com/apache/kafka/blob/trunk/config/kraft/broker.properties)  and the example [controller only config file](https://github.com/apache/kafka/blob/trunk/config/kraft/controller.properties)  that you reminded in [your email response](https://lists.apache.org/thread/11fh70rjzfpgwm3p3zhnzx1m1y23q82h)  to this [section](https://github.com/apache/kafka/blob/trunk/config/kraft/README.md#process-roles) of the Kraft mode README file. I know they are sitting right there next to the sample `server.properties` but I was so focused on that file that I didn't pay much attention to the other two when I first email the thread about broker-only and controller-only samples. 
   2. Regarding the [node numbers discussion in this section](https://github.com/apache/kafka/tree/trunk/config/kraft#quorum-voters) of README, please clarify if the node numbering is global i.e in the 10 broker example, given that 1,2,3 are taken by controllers, the brokers can only be numbered from 4 onwards. Or is the numbering scoped to the type of the node. That is can we have node ids 1,2,3 for brokers only nodes and again numbers 1,2,3 for dual-mode nodes. 
   
   Excited about the simplicity and scalability (large # of topics, faster leader selection etc)  that Kraft mode brings to Kafka and can't wait for production release. Thanks. 
   
   Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org