svn commit: r1465033 - /creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/Report.java

[se...@apache.org]

Author: sebb
Date: Fri Apr  5 16:42:17 2013
New Revision: 1465033

URL: http://svn.apache.org/r1465033
Log:
Fix more Eclipse warnings

Modified:
    creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/Report.java

Modified: creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/Report.java
URL: http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/Report.java?rev=1465033&r1=1465032&r2=1465033&view=diff
==============================================================================
--- creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/Report.java (original)
+++ creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/Report.java Fri Apr  5 16:42:17 2013
@@ -64,6 +64,7 @@ public class Report {
         } catch (ParseException e) {
             System.err.println("Please use the \"--help\" option to see a list of valid commands and options");
             System.exit(1);
+            return; // dummy return (won't be reached) to avoid Eclipse complaint about possible NPE for "cl"
         }
 
         if (cl.hasOption('h')) {
@@ -166,6 +167,7 @@ public class Report {
         "The copyright message to use in the licence headers, usually in the form of \"Copyright 2008 Foo\"");
         opts.addOption(copyright);
 
+        @SuppressWarnings("static-access") // ignore OptionBuilder design fault
         final Option exclude = OptionBuilder
                             .withArgName("expression")
                             .withLongOpt("exclude")
@@ -176,6 +178,7 @@ public class Report {
                             .create(EXCLUDE_CLI);
         opts.addOption(exclude);
 
+        @SuppressWarnings("static-access") // ignore OptionBuilder design fault
         final Option excludeFile = OptionBuilder
                             .withArgName("fileName")
                             .withLongOpt("exclude-file")