You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 04:43:29 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #12249: Add DataflowJobMessagesSensor and DataflowAutoscalingEventsSensor (Depends on: #11726)

mik-laj commented on a change in pull request #12249:
URL: https://github.com/apache/airflow/pull/12249#discussion_r521835730



##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -225,6 +243,67 @@ def _fetch_job_by_id(self, job_id: str) -> dict:
             .execute(num_retries=self._num_retries)
         )
 
+    def _fetch_list_job_messages_responses(self, job_id: str) -> Generator[dict, None, None]:
+        """
+        Helper method to fetch ListJobMessagesResponse with the specified Job ID.
+
+        :param job_id: Job ID to get.
+        :type job_id: str
+        :return: yields the ListJobMessagesResponse. See:
+            https://cloud.google.com/dataflow/docs/reference/rest/v1b3/ListJobMessagesResponse
+        :rtype: Generator[dict, None, None]
+        """
+        # raise Exception("error")

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org