You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/02/12 03:26:38 UTC
[GitHub] jeho0815 commented on a change in pull request #1084: [SCB-1139]
update vertx version from 3.5.3 to 3.6.2
jeho0815 commented on a change in pull request #1084: [SCB-1139] update vertx version from 3.5.3 to 3.6.2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1084#discussion_r255790684
##########
File path: dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
##########
@@ -163,6 +163,7 @@ private void refreshMembers(MemberDiscovery memberDiscovery) {
String configCenter = memberDiscovery.getConfigServer();
IpPort ipPort = NetUtils.parseIpPortFromURI(configCenter);
clientMgr.findThreadBindClientPool().runOnContext(client -> {
+ @SuppressWarnings("deprecation")
Review comment:
vertx 3.6.3 statement the interface is deprecated, but has not provider a new interface to replace, so we have to add the annotation to paas the CI buiding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services