You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/31 03:22:02 UTC
[GitHub] [incubator-doris] xiaoxiaopan118 opened a new pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
xiaoxiaopan118 opened a new pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532
FE logs ERROR (nioEventLoopGroup-3-2|84) [StaticResourceAction.executeGet():160] Request with wrong path. url: /static?res=DataTables-1.10.21/js/dataTables.bootstrap.js
because dataTables bootstrap js version differ, The thirdparty/vars.sh is 1.10.23, The WebBaseAction.java is 1.10.21.
We can consider through configuration way to perfect it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532#discussion_r704009711
##########
File path: fe/fe-core/src/main/java/org/apache/doris/http/action/WebBaseAction.java
##########
@@ -67,12 +67,12 @@
+ " rel=\"stylesheet\" media=\"screen\"/>"
+ " <link href=\"/static/css?res=Bootstrap-3.3.7/css/bootstrap-theme.css\" "
+ " rel=\"stylesheet\" media=\"screen\"/>"
- + " <link href=\"/static/css?res=DataTables-1.10.21/css/dataTables.bootstrap.css\" "
+ + " <link href=\"/static/css?res=DataTables-1.10.23/css/dataTables.bootstrap.css\" "
Review comment:
branch-0.14 is an old branch, your code will merge to master not branch, you should follow the latest code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532#discussion_r699840263
##########
File path: fe/fe-core/src/main/java/org/apache/doris/http/action/WebBaseAction.java
##########
@@ -67,12 +67,12 @@
+ " rel=\"stylesheet\" media=\"screen\"/>"
+ " <link href=\"/static/css?res=Bootstrap-3.3.7/css/bootstrap-theme.css\" "
+ " rel=\"stylesheet\" media=\"screen\"/>"
- + " <link href=\"/static/css?res=DataTables-1.10.21/css/dataTables.bootstrap.css\" "
+ + " <link href=\"/static/css?res=DataTables-1.10.23/css/dataTables.bootstrap.css\" "
Review comment:
the version in var.sh is 1.10.25 not 23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaoxiaopan118 commented on a change in pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
xiaoxiaopan118 commented on a change in pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532#discussion_r704157556
##########
File path: fe/fe-core/src/main/java/org/apache/doris/http/action/WebBaseAction.java
##########
@@ -67,12 +67,12 @@
+ " rel=\"stylesheet\" media=\"screen\"/>"
+ " <link href=\"/static/css?res=Bootstrap-3.3.7/css/bootstrap-theme.css\" "
+ " rel=\"stylesheet\" media=\"screen\"/>"
- + " <link href=\"/static/css?res=DataTables-1.10.21/css/dataTables.bootstrap.css\" "
+ + " <link href=\"/static/css?res=DataTables-1.10.23/css/dataTables.bootstrap.css\" "
Review comment:
close this pr, and push it to master branch, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532#discussion_r699840263
##########
File path: fe/fe-core/src/main/java/org/apache/doris/http/action/WebBaseAction.java
##########
@@ -67,12 +67,12 @@
+ " rel=\"stylesheet\" media=\"screen\"/>"
+ " <link href=\"/static/css?res=Bootstrap-3.3.7/css/bootstrap-theme.css\" "
+ " rel=\"stylesheet\" media=\"screen\"/>"
- + " <link href=\"/static/css?res=DataTables-1.10.21/css/dataTables.bootstrap.css\" "
+ + " <link href=\"/static/css?res=DataTables-1.10.23/css/dataTables.bootstrap.css\" "
Review comment:
the version in var.sh is 1.10.25 not 23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaoxiaopan118 commented on a change in pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
xiaoxiaopan118 commented on a change in pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532#discussion_r700674900
##########
File path: fe/fe-core/src/main/java/org/apache/doris/http/action/WebBaseAction.java
##########
@@ -67,12 +67,12 @@
+ " rel=\"stylesheet\" media=\"screen\"/>"
+ " <link href=\"/static/css?res=Bootstrap-3.3.7/css/bootstrap-theme.css\" "
+ " rel=\"stylesheet\" media=\"screen\"/>"
- + " <link href=\"/static/css?res=DataTables-1.10.21/css/dataTables.bootstrap.css\" "
+ + " <link href=\"/static/css?res=DataTables-1.10.23/css/dataTables.bootstrap.css\" "
Review comment:
on branch-0.14, var.sh is 1.10.23.
so if we change it as general config will better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaoxiaopan118 commented on pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
xiaoxiaopan118 commented on pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532#issuecomment-915018107
close this pr, and push it to master branch, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaoxiaopan118 closed pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
Posted by GitBox <gi...@apache.org>.
xiaoxiaopan118 closed pull request #6532:
URL: https://github.com/apache/incubator-doris/pull/6532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org