You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/08 03:26:12 UTC

[GitHub] [flink] wangxlong opened a new pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

wangxlong opened a new pull request #13559:
URL: https://github.com/apache/flink/pull/13559


   
   ## What is the purpose of the change
   
   Fix broken link of flink-architecture.md
   
   ## Brief change log
   
   Fix broken link of flink-architecture.md
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no / don't know)
     - The runtime per-record code paths (performance sensitive): (no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no / don't know)
     - The S3 file system connector: ( no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13559:
URL: https://github.com/apache/flink/pull/13559#issuecomment-705309728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7281",
       "triggerID" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7281) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangxlong commented on a change in pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #13559:
URL: https://github.com/apache/flink/pull/13559#discussion_r503925814



##########
File path: docs/concepts/flink-architecture.md
##########
@@ -169,7 +169,7 @@ A _Flink Application_ is any user program that spawns one or multiple Flink
 jobs from its ``main()`` method. The execution of these jobs can happen in a
 local JVM (``LocalEnvironment``) or on a remote setup of clusters with multiple
 machines (``RemoteEnvironment``). For each program, the
-[``ExecutionEnvironment``]({{ site.baseurl }}/api/java/) provides methods to
+[``ExecutionEnvironment``]({{ site.javadocs_baseurl }}/api/java/) provides methods to

Review comment:
       Yes, I close this pr, and open a issue to fix these.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] klion26 commented on a change in pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #13559:
URL: https://github.com/apache/flink/pull/13559#discussion_r503866701



##########
File path: docs/concepts/flink-architecture.md
##########
@@ -169,7 +169,7 @@ A _Flink Application_ is any user program that spawns one or multiple Flink
 jobs from its ``main()`` method. The execution of these jobs can happen in a
 local JVM (``LocalEnvironment``) or on a remote setup of clusters with multiple
 machines (``RemoteEnvironment``). For each program, the
-[``ExecutionEnvironment``]({{ site.baseurl }}/api/java/) provides methods to
+[``ExecutionEnvironment``]({{ site.javadocs_baseurl }}/api/java/) provides methods to

Review comment:
       @wangxlong I'm not very sure why the java doc links broken locally. maybe you need to generate the java doc locally before reaching to the doc.
   
   Thanks for checking the broken links. Could you please file an issue to fix the other broken links you mentioned?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13559:
URL: https://github.com/apache/flink/pull/13559#issuecomment-705307598


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0 (Thu Oct 08 03:28:28 UTC 2020)
   
   **Warnings:**
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangxlong commented on pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
wangxlong commented on pull request #13559:
URL: https://github.com/apache/flink/pull/13559#issuecomment-706545475


   cc @zentol @klion26 in your free time ~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13559:
URL: https://github.com/apache/flink/pull/13559#issuecomment-705309728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7281",
       "triggerID" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7281) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] klion26 commented on a change in pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #13559:
URL: https://github.com/apache/flink/pull/13559#discussion_r503055606



##########
File path: docs/concepts/flink-architecture.md
##########
@@ -169,7 +169,7 @@ A _Flink Application_ is any user program that spawns one or multiple Flink
 jobs from its ``main()`` method. The execution of these jobs can happen in a
 local JVM (``LocalEnvironment``) or on a remote setup of clusters with multiple
 machines (``RemoteEnvironment``). For each program, the
-[``ExecutionEnvironment``]({{ site.baseurl }}/api/java/) provides methods to
+[``ExecutionEnvironment``]({{ site.javadocs_baseurl }}/api/java/) provides methods to

Review comment:
       Why do we need to change this?
   Seems the link is correct and reachable. (test use [documentation of 1.11](https://ci.apache.org/projects/flink/flink-docs-release-1.11/concepts/flink-architecture.html#flink-application-execution))




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13559:
URL: https://github.com/apache/flink/pull/13559#issuecomment-705309728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangxlong closed pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
wangxlong closed pull request #13559:
URL: https://github.com/apache/flink/pull/13559


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13559: [Hotfix][Docs] Fix broken link of flink-architecture.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13559:
URL: https://github.com/apache/flink/pull/13559#issuecomment-705309728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7281",
       "triggerID" : "4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4de3c79dd9c54c4ce6fd1b68dc9d4b0a953080c0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7281) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org