You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/28 00:38:09 UTC
[GitHub] [tvm] zxybazh opened a new pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass
zxybazh opened a new pull request #7936:
URL: https://github.com/apache/tvm/pull/7936
This PR introduces tir level op legalization function registration to current tvm stack and injects the legalization function when no intrinsic lowering function is available. Currently the legalization functions are target-dependent. Previous legalization functions are migrated to the legelization function registry as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7936:
URL: https://github.com/apache/tvm/pull/7936#issuecomment-830553396
This PR looks good to me. @tqchen @anijain2305 @zhiics Please let me know if there are any further comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7936:
URL: https://github.com/apache/tvm/pull/7936#issuecomment-830237054
@zxybazh The PR looks good. Please retrigger the CI :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #7936:
URL: https://github.com/apache/tvm/pull/7936#issuecomment-829465951
IMHO, the intrinsic lowering pass logic is already in `src/tir` and the intrinsic lowering ruls are more target dependent so I think it's okay if we keep those rules in `src/target`. However, since it's pure tir level manipulation, I would be fine if we want to move all intrinsic lowering and legalization rules to `src/tir/intrin` and `src/tir/legalization`, and manage them together. Would like to see how others think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7936:
URL: https://github.com/apache/tvm/pull/7936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7936:
URL: https://github.com/apache/tvm/pull/7936#issuecomment-829457725
@tqchen @zxybazh I am thinking if we should move the intrinsic registeration logic to `src/tir/intrin`, given it is part of TIR and is logically closer to IR manipulation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org