You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/05 21:48:51 UTC

Re: Review Request 33784: Update upstart configurations along with sources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33784/
-----------------------------------------------------------

(Updated May 5, 2015, 7:48 p.m.)


Review request for Aurora and Kevin Sweeney.


Changes
-------

Fixed issue discovered when creating a new vagrant image.


Summary (updated)
-----------------

Update upstart configurations along with sources.


Bugs: AURORA-1204
    https://issues.apache.org/jira/browse/AURORA-1204


Repository: aurora


Description (updated)
-------

It turns out a symlink doesn't work too nicely for this, as upstart doesn't play nicely with symlinks (possibly only when the destination is not on the root file system).  The only way i could get upstart to recognize symlinked files was to run `initctl reload-configuration` upon creation and any time they changed.  Copying the files does not have this issue.


Diffs (updated)
-----

  examples/vagrant/provision-dev-cluster.sh e7fdd4b7f5bdfcbe16f8ace1cef0dba00376aa81 

Diff: https://reviews.apache.org/r/33784/diff/


Testing (updated)
-------

End-to-end tests pass.


Thanks,

Bill Farner