You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/04/20 20:13:22 UTC

[GitHub] [incubator-eventmesh] RSTdefg opened a new pull request, #842: [ISSUE #838] Removed redundant code

RSTdefg opened a new pull request, #842:
URL: https://github.com/apache/incubator-eventmesh/pull/842

   Fixes ISSUE #<838>.
   
   ### Motivation
   
   First time contributor working on another starter issue.
   
   
   
   ### Modifications
   
   Removed unused code blocks from files listed in the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] RSTdefg commented on pull request #842: [ISSUE #838] Removed redundant code

Posted by GitBox <gi...@apache.org>.
RSTdefg commented on PR #842:
URL: https://github.com/apache/incubator-eventmesh/pull/842#issuecomment-1106654795

   > @RSTdefg Hi, this issue #838 is `good first issue` and the change points required are very simple and are set up for new contributors. We do not recommend that one person be responsible for multiple `good first issues`. So I'll merge this pr and close the #841. I hope you can understand, and will have the opportunity to participate in more challenging tasks later, thanks. 
   
   I see, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #842: [ISSUE #838] Removed redundant code

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #842:
URL: https://github.com/apache/incubator-eventmesh/pull/842#issuecomment-1105940959

   @RSTdefg Hi, this issue #838 is good first issue and the change points required are very simple and are set up for new contributors. We do not recommend that one person be responsible for multiple good first issues. So I'll merge this pr and close the #841. I hope you can understand, and will have the opportunity to participate in more challenging tasks later, thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 merged pull request #842: [ISSUE #838] Removed redundant code

Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #842:
URL: https://github.com/apache/incubator-eventmesh/pull/842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org