You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/06/26 23:40:31 UTC

[GitHub] cordova-lib pull request: CB-7037 platform check doesn't warn when...

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-lib/pull/42

    CB-7037 platform check doesn't warn when it can't install a platform

    cordova platform check will now report when:
     * it can't create a platform
     * it can't run a new platform version script
     * a new platform version script doesn't report a version

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsoref/cordova-lib cb_7037

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit cd2c47e2a4ea936e0507a2214cebae0a75b86d46
Author: Josh Soref <js...@blackberry.com>
Date:   2014-06-26T21:38:45Z

    CB-7037 platform check doesn't warn when it can't install a platform
    
    cordova platform check will now report when:
     * it can't create a platform
     * it can't run a new platform version script
     * a new platform version script doesn't report a version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-7037 platform check doesn't warn when...

Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/42#issuecomment-47793655
  
    Looks good, ship it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: CB-7037 platform check doesn't warn when...

Posted by jsoref <gi...@git.apache.org>.
Github user jsoref closed the pull request at:

    https://github.com/apache/cordova-lib/pull/42


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---