You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Created) (JIRA)" <ji...@apache.org> on 2011/11/11 23:22:51 UTC

[jira] [Created] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Gossiper.addSavedEndpoint should never add itself
-------------------------------------------------

                 Key: CASSANDRA-3485
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
             Project: Cassandra
          Issue Type: Bug
          Components: Core
            Reporter: Brandon Williams
            Assignee: Brandon Williams
             Fix For: 0.8.8


Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-3485:
----------------------------------------

    Description: Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.  (was: Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up nodes using a generation of zero and thus never being marked as alive.)
    
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.8
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-3485:
----------------------------------------

    Fix Version/s: 1.0.6
    
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 3
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.9, 1.0.6
>
>         Attachments: 3485.txt
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-3485:
----------------------------------------

    Affects Version/s: 0.7 beta 3
    
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 3
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.8
>
>         Attachments: 3485.txt
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3485:
--------------------------------------

    Reviewer: thepaul
    
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 3
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.8
>
>         Attachments: 3485.txt
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166833#comment-13166833 ] 

Hudson commented on CASSANDRA-3485:
-----------------------------------

Integrated in Cassandra-0.8 #416 (See [https://builds.apache.org/job/Cassandra-0.8/416/])
    Prevent gossiper from adding itself to saved endpoints.
Patch by brandonwilliams reviewed by Paul Cannon for CASSANDRA-3485.

brandonwilliams : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212624
Files : 
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/SystemTable.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java

                
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 3
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.9, 1.0.6
>
>         Attachments: 3485.txt
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-3485:
----------------------------------------

    Attachment: 3485.txt

Patch to prevent adding our own endpoint to saved endpoints, and if detected, remove it.
                
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.8
>
>         Attachments: 3485.txt
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148785#comment-13148785 ] 

Brandon Williams commented on CASSANDRA-3485:
---------------------------------------------

Note that you can get around this with -Dcassandra.load_ring_state=false
                
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.8
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3485) Gossiper.addSavedEndpoint should never add itself

Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166528#comment-13166528 ] 

paul cannon commented on CASSANDRA-3485:
----------------------------------------

+1.
                
> Gossiper.addSavedEndpoint should never add itself
> -------------------------------------------------
>
>                 Key: CASSANDRA-3485
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3485
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 3
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>             Fix For: 0.8.9
>
>         Attachments: 3485.txt
>
>
> Somehow, people are running into a situation where nodes are adding themselves to the persisted ring cache.  Since SS is initialized after the Gossiper and calls addSavedEndpoint on it, which inits the nodes with a generation of zero, this ends up with nodes using a generation of zero and thus never being marked as alive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira