You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <pl...@linkedin.com> on 2010/05/14 01:26:17 UTC

[2.0] Removing some @Deprecated classes/methods/features

I'm starting some cleanup getting ready for 2.0.  This involves removing
some deprecated code.  The only one that we might want to keep is legacy
body signing and/or strict content checks.  I'm going to remove it for now.
 If anyone needs it for 2.x let me know and I'll revert.

* SocialSpiException class is removed, use ProtocolException instead

* GuiceBeanConverter.DuplicateFieldException class is removed

* RestfulCollection

The constructor RestfulCollection(List<T> entry, int startIndex, int
totalResults) is removed.
Use the constructor with an items-per-page parameter instead.

Re: [2.0] Removing some @Deprecated classes/methods/features

Posted by Paul Lindner <pl...@linkedin.com>.
Sounds like a very convenient method.  Most containers are going to adhere
to what the client asks for.  We'd still need to the multi-args version for
containers that wish to ignore the client or have an indeterminate response.

On Thu, May 13, 2010 at 9:13 PM, Chirag Shah <ch...@gmail.com> wrote:

> While we're at it.. what do you think about adding
> RestfulCollection(List<T> entry, CollectionOptions options), and
> deducing startIndex (from options), totalResults (from entry),
> itemsPerPage (from options)?
>
> Thanks,
> Chirag
>
> On Thu, May 13, 2010 at 4:26 PM, Paul Lindner <pl...@linkedin.com>
> wrote:
> > I'm starting some cleanup getting ready for 2.0.  This involves removing
> > some deprecated code.  The only one that we might want to keep is legacy
> > body signing and/or strict content checks.  I'm going to remove it for
> now.
> >  If anyone needs it for 2.x let me know and I'll revert.
> >
> > * SocialSpiException class is removed, use ProtocolException instead
> >
> > * GuiceBeanConverter.DuplicateFieldException class is removed
> >
> > * RestfulCollection
> >
> > The constructor RestfulCollection(List<T> entry, int startIndex, int
> > totalResults) is removed.
> > Use the constructor with an items-per-page parameter instead.
> >
>

Re: [2.0] Removing some @Deprecated classes/methods/features

Posted by Chirag Shah <ch...@gmail.com>.
While we're at it.. what do you think about adding
RestfulCollection(List<T> entry, CollectionOptions options), and
deducing startIndex (from options), totalResults (from entry),
itemsPerPage (from options)?

Thanks,
Chirag

On Thu, May 13, 2010 at 4:26 PM, Paul Lindner <pl...@linkedin.com> wrote:
> I'm starting some cleanup getting ready for 2.0.  This involves removing
> some deprecated code.  The only one that we might want to keep is legacy
> body signing and/or strict content checks.  I'm going to remove it for now.
>  If anyone needs it for 2.x let me know and I'll revert.
>
> * SocialSpiException class is removed, use ProtocolException instead
>
> * GuiceBeanConverter.DuplicateFieldException class is removed
>
> * RestfulCollection
>
> The constructor RestfulCollection(List<T> entry, int startIndex, int
> totalResults) is removed.
> Use the constructor with an items-per-page parameter instead.
>

Re: [2.0] Removing some @Deprecated classes/methods/features

Posted by Ziv Horesh <zh...@gmail.com>.
On Fri, May 14, 2010 at 5:59 PM, Paul Lindner <li...@inuus.com> wrote:

>
> On May 14, 2010, at 3:55 PM, Ziv Horesh wrote:
>
> >
> > What the arm in leaving this constructor? It simplify call that do not
> want
> > pages.
> > It seems we use this constructor heavily in our code base...
>
> If it's a problem then sure, go ahead revert.  It was Deprecated last
> October as part of SHINDIG-1117.
>
> Ok, I just wonder if I can un-deprecated  it as well.
It is basically a helper constructor when the user don't need paging.
I am not totally familiar with the code here so I wonder if I missed
something?

Re: [2.0] Removing some @Deprecated classes/methods/features

Posted by Paul Lindner <li...@inuus.com>.
On May 14, 2010, at 3:55 PM, Ziv Horesh wrote:

> 
> What the arm in leaving this constructor? It simplify call that do not want
> pages.
> It seems we use this constructor heavily in our code base...

If it's a problem then sure, go ahead revert.  It was Deprecated last October as part of SHINDIG-1117.


Re: [2.0] Removing some @Deprecated classes/methods/features

Posted by Ziv Horesh <zh...@gmail.com>.
On Thu, May 13, 2010 at 4:26 PM, Paul Lindner <pl...@linkedin.com> wrote:

> I'm starting some cleanup getting ready for 2.0.  This involves removing
> some deprecated code.  The only one that we might want to keep is legacy
> body signing and/or strict content checks.  I'm going to remove it for now.
>  If anyone needs it for 2.x let me know and I'll revert.
>
> * SocialSpiException class is removed, use ProtocolException instead
>
> * GuiceBeanConverter.DuplicateFieldException class is removed
>
> * RestfulCollection
>
> The constructor RestfulCollection(List<T> entry, int startIndex, int
> totalResults) is removed.
> Use the constructor with an items-per-page parameter instead.
>

What the arm in leaving this constructor? It simplify call that do not want
pages.
It seems we use this constructor heavily in our code base...