You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by al...@apache.org on 2023/04/16 11:19:44 UTC
[arrow] branch main updated: GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` (#35108)
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 4328ebac62 GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` (#35108)
4328ebac62 is described below
commit 4328ebac629b2c023b8d83d0329dd791cfa16aa7
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Sun Apr 16 07:19:36 2023 -0400
GH-35107: [FlightSQL]: Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` (#35108)
### Rationale for this change
The spec is inconsistent -- see details on https://github.com/apache/arrow/issues/35107
### What changes are included in this PR?
Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`
### Are these changes tested?
No, they are comment only changed
### Are there any user-facing changes?
This clarifies a small corner case in the document
* Closes: #35107
Authored-by: Andrew Lamb <an...@nerdnetworks.org>
Signed-off-by: Andrew Lamb <an...@nerdnetworks.org>
---
format/FlightSql.proto | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/format/FlightSql.proto b/format/FlightSql.proto
index d8a6cb5bfd..ad427fd809 100644
--- a/format/FlightSql.proto
+++ b/format/FlightSql.proto
@@ -1324,8 +1324,8 @@ enum UpdateDeleteRules {
* key_sequence: int not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
- * update_rule: uint1 not null,
- * delete_rule: uint1 not null
+ * update_rule: uint8 not null,
+ * delete_rule: uint8 not null
* >
* The returned data should be ordered by fk_catalog_name, fk_db_schema_name, fk_table_name, fk_key_name, then key_sequence.
* update_rule and delete_rule returns a byte that is equivalent to actions declared on UpdateDeleteRules enum.
@@ -1370,8 +1370,8 @@ message CommandGetExportedKeys {
* key_sequence: int not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
- * update_rule: uint1 not null,
- * delete_rule: uint1 not null
+ * update_rule: uint8 not null,
+ * delete_rule: uint8 not null
* >
* The returned data should be ordered by pk_catalog_name, pk_db_schema_name, pk_table_name, pk_key_name, then key_sequence.
* update_rule and delete_rule returns a byte that is equivalent to actions:
@@ -1423,8 +1423,8 @@ message CommandGetImportedKeys {
* key_sequence: int not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
- * update_rule: uint1 not null,
- * delete_rule: uint1 not null
+ * update_rule: uint8 not null,
+ * delete_rule: uint8 not null
* >
* The returned data should be ordered by pk_catalog_name, pk_db_schema_name, pk_table_name, pk_key_name, then key_sequence.
* update_rule and delete_rule returns a byte that is equivalent to actions: