You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/03/15 10:39:36 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #7617: [INLONG-7616][Manager] Fix failed to obtain audit information
fuweng11 opened a new pull request, #7617:
URL: https://github.com/apache/inlong/pull/7617
### Prepare a Pull Request
- Fixes #7616
### Motivation
Fix failed to obtain audit information.
### Modifications
Fix failed to obtain audit information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7617: [INLONG-7616][Manager] Fix failed to obtain audit information
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7617:
URL: https://github.com/apache/inlong/pull/7617#discussion_r1136882703
##########
inlong-manager/manager-dao/src/main/resources/mappers/AuditBaseEntityMapper.xml:
##########
@@ -66,12 +66,8 @@
<include refid="Base_Column_List"/>
from audit_base
<where>
- <if test="type != null and type != ''">
- and type = #{type, jdbcType=VARCHAR}
- </if>
- <if test="isSent != null and isSent != ''">
- and is_sent = #{isSent,jdbcType=INTEGER}
- </if>
+ and type = #{type, jdbcType=VARCHAR}
Review Comment:
Maybe change to the following is better:
```sql
where
type = #{type, jdbcType=VARCHAR}
and is_sent = #{isSent, jdbcType=INTEGER}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7617: [INLONG-7616][Manager] Fix failed to obtain audit information
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7617:
URL: https://github.com/apache/inlong/pull/7617#discussion_r1136882703
##########
inlong-manager/manager-dao/src/main/resources/mappers/AuditBaseEntityMapper.xml:
##########
@@ -66,12 +66,8 @@
<include refid="Base_Column_List"/>
from audit_base
<where>
- <if test="type != null and type != ''">
- and type = #{type, jdbcType=VARCHAR}
- </if>
- <if test="isSent != null and isSent != ''">
- and is_sent = #{isSent,jdbcType=INTEGER}
- </if>
+ and type = #{type, jdbcType=VARCHAR}
Review Comment:
Maybe change to is better:
```sql
where
type = #{type, jdbcType=VARCHAR}
and is_sent = #{isSent, jdbcType=INTEGER}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7617: [INLONG-7616][Manager] Fix failed to obtain audit information
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7617:
URL: https://github.com/apache/inlong/pull/7617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7617: [INLONG-7616][Manager] Fix failed to obtain audit information
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7617:
URL: https://github.com/apache/inlong/pull/7617#discussion_r1136881342
##########
inlong-manager/manager-dao/src/main/resources/mappers/AuditBaseEntityMapper.xml:
##########
@@ -66,12 +66,8 @@
<include refid="Base_Column_List"/>
from audit_base
<where>
- <if test="type != null and type != ''">
- and type = #{type, jdbcType=VARCHAR}
- </if>
- <if test="isSent != null and isSent != ''">
- and is_sent = #{isSent,jdbcType=INTEGER}
- </if>
+ and type = #{type, jdbcType=VARCHAR}
Review Comment:
Is the first `and` necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7617: [INLONG-7616][Manager] Fix failed to obtain audit information
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7617:
URL: https://github.com/apache/inlong/pull/7617#discussion_r1136885605
##########
inlong-manager/manager-dao/src/main/resources/mappers/AuditBaseEntityMapper.xml:
##########
@@ -66,12 +66,8 @@
<include refid="Base_Column_List"/>
from audit_base
<where>
- <if test="type != null and type != ''">
- and type = #{type, jdbcType=VARCHAR}
- </if>
- <if test="isSent != null and isSent != ''">
- and is_sent = #{isSent,jdbcType=INTEGER}
- </if>
+ and type = #{type, jdbcType=VARCHAR}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org