[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #13: SLING-9695 Added options for datastore

[GitBox <gi...@apache.org>]

rombert commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682178850


   Thanks for the update. I am not sure we should be generating so many aggregates ... we have a large number of combinations of NodeStores and DataStores, e.g.
   
   - SegmentNodeStore
   - DocumentNodeStore + MongoDB
   - DocumentNodeStore + RDB (Postgres?)
   
   - No BlobStore
   - FileBlobStore
   - MongoBlobStore
   - RDBBlobStore
   (etc, etc)
   
   The idea behind having an additional file which configures just the DataStore was to combine one NodeStore with one DataStore, instead of 'hardcoding' combinations. Additionally, if we generate `far` files as well, we greatly increase the storage needed. But I should think about this some more tomorrow, it's a bit late over here right now :-)
   
   About the hardcoded path, I think you can work around it by defining another variable
   
   ```
       "variables": {
           "repository.home": "${sling.home}/repository"
       }
   ```
   
   And then referencing `${repository.home}` in the configuration values.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org