You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/05/10 12:47:41 UTC
Re: Review Request 59015: Implemented passing docker config depended
methods.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/
-----------------------------------------------------------
(Updated May 10, 2017, 5:47 a.m.)
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Summary (updated)
-----------------
Implemented passing docker config depended methods.
Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088
Repository: mesos
Description (updated)
-------
Implemented passing docker config depended methods.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
Diff: https://reviews.apache.org/r/59015/diff/2/
Changes: https://reviews.apache.org/r/59015/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Gilbert Song <so...@gmail.com>.
> On May 10, 2017, 3:13 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/59015/diff/2/?file=1713945#file1713945line87>
> >
> > s/Secret::Value/JSON::Object/
> >
> > This file doesn't need to know about secrets AFAICT?
Chatted offline. We will move the getAuthHeader to fetch() to avoid new parameter. Will follow up with the refactor.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review174580
-----------------------------------------------------------
On May 10, 2017, 5:47 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 5:47 a.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented passing docker config depended methods.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
>
>
> Diff: https://reviews.apache.org/r/59015/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review174580
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 87 (patched)
<https://reviews.apache.org/r/59015/#comment247729>
s/Secret::Value/JSON::Object/
This file doesn't need to know about secrets AFAICT?
- Vinod Kone
On May 10, 2017, 12:47 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 12:47 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented passing docker config depended methods.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
>
>
> Diff: https://reviews.apache.org/r/59015/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review175746
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 22, 2017, 5:59 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 5:59 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented passing docker config depended methods.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
>
>
> Diff: https://reviews.apache.org/r/59015/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review175833
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 23, 2017, 5:54 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 5:54 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented passing docker config depended methods.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
>
>
> Diff: https://reviews.apache.org/r/59015/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/
-----------------------------------------------------------
(Updated May 23, 2017, 10:54 a.m.)
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Changes
-------
Addressed Chun's comments.
Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088
Repository: mesos
Description
-------
Implemented passing docker config depended methods.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
Diff: https://reviews.apache.org/r/59015/diff/4/
Changes: https://reviews.apache.org/r/59015/diff/3-4/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review175742
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 87 (patched)
<https://reviews.apache.org/r/59015/#comment249100>
I think we don't need a default here.
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 101 (patched)
<https://reviews.apache.org/r/59015/#comment249101>
Ditto.
- Chun-Hung Hsiao
On May 22, 2017, 5:59 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 5:59 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented passing docker config depended methods.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
>
>
> Diff: https://reviews.apache.org/r/59015/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59015: Implemented passing docker config depended
methods.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/
-----------------------------------------------------------
(Updated May 22, 2017, 10:59 a.m.)
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088
Repository: mesos
Description
-------
Implemented passing docker config depended methods.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b
Diff: https://reviews.apache.org/r/59015/diff/3/
Changes: https://reviews.apache.org/r/59015/diff/2-3/
Testing
-------
make check
Thanks,
Gilbert Song