You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Eric Pugh (Jira)" <ji...@apache.org> on 2024/02/02 14:20:00 UTC

[jira] [Commented] (SOLR-17147) To commit or not to commit? That is the question on bin/solr post

    [ https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813694#comment-17813694 ] 

Eric Pugh commented on SOLR-17147:
----------------------------------

Another thought is to look at the params on bin/solr post and see if some are covered elsewhere and could be removed.   I don't think we have a bin/solr optimize command, but if we did, then we wouldn't need it on hte post command for example...

> To commit or not to commit?  That is the question on bin/solr post
> ------------------------------------------------------------------
>
>                 Key: SOLR-17147
>                 URL: https://issues.apache.org/jira/browse/SOLR-17147
>             Project: Solr
>          Issue Type: Sub-task
>          Components: cli
>    Affects Versions: 9.5
>            Reporter: Eric Pugh
>            Assignee: Eric Pugh
>            Priority: Minor
>
> The way we have set up most boolean options in the bin/solr is that you specific the option to mean "true".   Versus doing a "option=true" or "option=false".    In the bin/post command, the commit is a explicit true/false, and if you don't specifiy it, then there is automatically a commit.   However, with bin/solr post, if you don't specify -commit, then you don't get a commit.   
> Which makes sense from how the options are laid out "yes I want to opt into a commit", however I suspect the vast majority of users who use the command will immediatly go look for the doc, and wonder why it isn't visible..  which is proably why bin/post commits if you don't specify it.
> Our options are to have an explicit -commit=true/false OR we commit by default and have a -nocommit option.   
> I guess I am leaning towards having a -nocommit as a boolean option, so that wihtout it you get the commit...   
> Fortunantly optimize story is better.  by default we do NOT issue an optimize, but you can do -optimize to requiest that ;-).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org