You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/29 06:44:30 UTC

[GitHub] [dubbo] plusmancn opened a new issue #8633: [CodeReview 3.0] Dubbo in spring

plusmancn opened a new issue #8633:
URL: https://github.com/apache/dubbo/issues/8633


   ### 1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.
   DubboConfigConfigurationRegistrar only has one function call:
   ```java
   public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
       // initialize dubbo beans
       DubboSpringInitializer.initialize(registry);
   }
   ```
   but DubboComponentScanRegistrar also has this function call:
   ```java
   public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
       // initialize dubbo beans
       DubboSpringInitializer.initialize(registry);
   
       Set<String> packagesToScan = getPackagesToScan(importingClassMetadata);
   
       registerServiceAnnotationPostProcessor(packagesToScan, registry);
   }
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] plusmancn commented on issue #8633: [CodeReview 3.0] Dubbo in spring

Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8633:
URL: https://github.com/apache/dubbo/issues/8633#issuecomment-910313900


   ### 2) ServiceBean has nothing to do with FactoryBean
   ```java
   /**
    * ServiceFactoryBean <= HERE
    *
    * @export
    */
   public class ServiceBean<T> extends ServiceConfig<T> implements InitializingBean, DisposableBean,
           ApplicationContextAware, BeanNameAware, ApplicationEventPublisherAware {
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on issue #8633: [CodeReview 3.0] Dubbo in spring

Posted by GitBox <gi...@apache.org>.
kylixs commented on issue #8633:
URL: https://github.com/apache/dubbo/issues/8633#issuecomment-951921937


   > ### 1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.
   > DubboConfigConfigurationRegistrar only has one function call:
   > but DubboComponentScanRegistrar also has this function call:
   
   They are not duplicated.
   `DubboConfigConfigurationRegistrar` is handler of annotation `@EnableDubboConfig` ,  `DubboComponentScanRegistrar ` is handler of annotation `@DubboComponentScan`,  they are different entry point, user can use one of the annotation.
   
   
   > 2) ServiceBean has nothing to do with FactoryBean
   
   Yes, ServiceBean is not a FactoryBean but only a hidden service config bean for export service.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org