You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/19 10:30:33 UTC

[GitHub] [incubator-druid] clintropolis opened a new pull request #8907: add google cloud storage InputSource for native batch

clintropolis opened a new pull request #8907: add google cloud storage InputSource for native batch
URL: https://github.com/apache/incubator-druid/pull/8907
 
 
   ## Description
   Another follow up to #8823, this PR adds a Google CloudStorage `InputSource` and `InputEntity` implementation allowing it to be used with the new native batch indexing interfaces. This implementation differs from the `StaticGoogleBlobStoreFirehoseFactory` in that it uses a `uris` list like the `S3InputSource` rather than a `blobs` list.
   
   ```
   ...
       "ioConfig": {
         "type": "index_parallel",
         "inputSource": {
           "type": "google",
           "uris": ["gs://some/path/file.json", "gs://some/other/path/file2.json"]
         },
         "inputFormat": {
           "type": "json"
         },
         "appendToExisting": false
       },
   ...
   ```
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `GoogleCloudStorageInputSource` 
    * `GoogleCloudStorageEntity`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org