You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/05/30 01:15:58 UTC
[GitHub] [sling-jspc-maven-plugin] rmkellogg opened a new pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml
rmkellogg opened a new pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4
When the jspc Maven plugin is used within a project open in Eclipse, it generates an warning related to unknown lifecycle. The attached metadata file resolves this issue following the advice obtained here:
https://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] rombert commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851294580
Thanks for your submission @rmkellogg ! The build failed since the file you added is missing a copyright header, can you please add one?
It should be the same one as in https://github.com/apache/sling-jspc-maven-plugin/blob/master/pom.xml .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] rombert merged pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml
Posted by GitBox <gi...@apache.org>.
rombert merged pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] rombert commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851459436
PR merged, thanks @rmkellogg ! Note that I decided we still need a Jira issue for it since it affects end users so I created https://issues.apache.org/jira/browse/SLING-10439 . In the future please also create those unless the changes are trivial (formatting, typos).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] rmkellogg commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml
Posted by GitBox <gi...@apache.org>.
rmkellogg commented on pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851449070
Missing copyright header added. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] sonarcloud[bot] commented on pull request #4: Added missing Eclipse M2Eclipse lifecycle-mapping-metadata.xml
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/4#issuecomment-851449590
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=4&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin&pullRequest=4&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin&pullRequest=4&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org