[jira] [Commented] (KNOX-1036) Fix a number of issues relating to JWTokenAuthority

["Larry McCay (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172546#comment-16172546 ] 

Larry McCay commented on KNOX-1036:
-----------------------------------

[~coheigea] - LGTM
Please be sure to test this manually as well - as it is obviously core to our authentication services, KnoxSSO and KnoxToken support.
Once you have tested it manually you have my +1.


> Fix a number of issues relating to JWTokenAuthority
> ---------------------------------------------------
>
>                 Key: KNOX-1036
>                 URL: https://issues.apache.org/jira/browse/KNOX-1036
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Trivial
>             Fix For: 0.14.0
>
>         Attachments: 0001-KNOX-1036-Fix-a-number-of-issues-relating-to-JWToken.patch
>
>
> This task is to fix a number of issues relating to JWTokenAuthority:
> a) Change JWTToken to JWT in JWTokenAuthority. We should program to interfaces not implementations.
> b) Change issueToken(Principal p, String audience, long l) to issueToken(Principal p, String algorithm, long expires). The code that uses this method interprets the second parameter as "algorithm" not "audience".
> c) Add "boolean verify(JWSVerifier verifier);" into JWT - previously it was only in JWTToken.
> d) Remove unneeded "public abstract" definitions from JWT interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)