You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/11/29 22:36:08 UTC

Review Request 54182: Improved various comments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54182/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Improved various comments.


Diffs
-----

  src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8 
  src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 
  src/tests/partition_tests.cpp 5a0d4bd2de6a5aa0e9fdf0d34cd10d16fd4e34a1 

Diff: https://reviews.apache.org/r/54182/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 54182: Improved various comments.

Posted by Neil Conway <ne...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54182/
-----------------------------------------------------------

(Updated Dec. 12, 2016, 7:05 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase.


Repository: mesos


Description
-------

Improved various comments.


Diffs (updated)
-----

  src/master/master.hpp c304e69af0b7a720ea8277088cabc0675eec8b57 
  src/master/master.cpp 8c1c7f94102a2f40fbdffaa36f2d1c15e78a906d 
  src/tests/partition_tests.cpp 00cc815529dc4d303db638680eacb8f55713d1a1 

Diff: https://reviews.apache.org/r/54182/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 54182: Improved various comments.

Posted by Neil Conway <ne...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54182/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 2:37 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address review comments.


Repository: mesos


Description
-------

Improved various comments.


Diffs (updated)
-----

  src/master/master.hpp d3c20d7cbb9137d3b05cae3d67f004d5e7475c8a 
  src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 
  src/tests/partition_tests.cpp 00cc815529dc4d303db638680eacb8f55713d1a1 

Diff: https://reviews.apache.org/r/54182/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 54182: Improved various comments.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54182/#review158611
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp (line 2594)
<https://reviews.apache.org/r/54182/#comment229392>

    s/state/state and have all updates acknowledged/



src/master/master.cpp (line 5408)
<https://reviews.apache.org/r/54182/#comment229393>

    neglect to "remove" non-partition-aware?


- Vinod Kone


On Nov. 29, 2016, 10:36 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54182/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved various comments.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8 
>   src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 
>   src/tests/partition_tests.cpp 5a0d4bd2de6a5aa0e9fdf0d34cd10d16fd4e34a1 
> 
> Diff: https://reviews.apache.org/r/54182/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>