You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/14 13:31:42 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'
URL: https://github.com/apache/airflow/pull/5913#discussion_r346311207
 
 

 ##########
 File path: tests/sensors/test_sql_sensor.py
 ##########
 @@ -103,6 +103,18 @@ def test_sql_sensor_postgres_poke(self, mock_hook):
         mock_get_records.return_value = []
         self.assertFalse(t.poke(None))
 
+        mock_get_records.return_value = [['None']]
 
 Review comment:
   This is when it returns the string `"None"` ritght?
   
   Shouldn't we also have a case where we test the behaviour with `[[None]]` as the return?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services