You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2008/09/16 14:16:44 UTC
[jira] Created: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Move LineRecordReader.LineReader class to util package
------------------------------------------------------
Key: HADOOP-4186
URL: https://issues.apache.org/jira/browse/HADOOP-4186
Project: Hadoop Core
Issue Type: Sub-task
Reporter: Tom White
Assignee: Tom White
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-4186:
------------------------------
Attachment: hadoop-4186.patch
Patch that deprecates LineRecordReader.LineReader in favour of a new LineReader class in util.
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631467#action_12631467 ]
Doug Cutting commented on HADOOP-4186:
--------------------------------------
+1 This looks good to me.
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4186:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.19.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Tom!
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631817#action_12631817 ]
Hadoop QA commented on HADOOP-4186:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390193/hadoop-4186.patch
against trunk revision 696228.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/console
This message is automatically generated.
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633317#action_12633317 ]
Hudson commented on HADOOP-4186:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4186:
------------------------------------
Component/s: mapred
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: mapred
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631476#action_12631476 ]
Pete Wyckoff commented on HADOOP-4186:
--------------------------------------
is the goal of this to create a LineReader deserializer? just wanted to know since i did do that for the unit tests for https://issues.apache.org/jira/browse/HADOOP-4065
I have also implemented RecordIODeserializer .
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-4186:
------------------------------
Status: Patch Available (was: Open)
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631714#action_12631714 ]
Tom White commented on HADOOP-4186:
-----------------------------------
bq. is the goal of this to create a LineReader deserializer?
No, it is purely to break the dependency that the core module has on mapred.
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4186) Move LineRecordReader.LineReader
class to util package
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631481#action_12631481 ]
Pete Wyckoff commented on HADOOP-4186:
--------------------------------------
Note this issue also relates to: https://issues.apache.org/jira/browse/HADOOP-4192 if we are starting to make Deserializers out of existing RecordReaders ...
> Move LineRecordReader.LineReader class to util package
> ------------------------------------------------------
>
> Key: HADOOP-4186
> URL: https://issues.apache.org/jira/browse/HADOOP-4186
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-4186.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.