You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2019/02/21 09:28:25 UTC
[GitHub] andrei-ivanov commented on a change in pull request #514: Configure
media types in bean for logging intercepters
andrei-ivanov commented on a change in pull request #514: Configure media types in bean for logging intercepters
URL: https://github.com/apache/cxf/pull/514#discussion_r258843220
##########
File path: rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/DefaultLogEventMapper.java
##########
@@ -46,17 +44,25 @@
import org.apache.cxf.ws.addressing.ContextUtils;
public class DefaultLogEventMapper {
- private static final Set<String> BINARY_CONTENT_MEDIA_TYPES;
+ private static final Set<String> DEFAULT_BINARY_CONTENT_MEDIA_TYPES;
Review comment:
Trivial improvement suggestion: since this field seems to want to be immutable, I think it's better to initialize it like this: https://github.com/spring-projects/spring-framework/blob/master/spring-context/src/main/java/org/springframework/format/datetime/DateTimeFormatAnnotationFormatterFactory.java#L43
I know this PR just renames the field, but maybe the initialization can be improved too 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services